From 2614ca0e7eddd9ccda2eb01b53eef0d2e8a3d6f4 Mon Sep 17 00:00:00 2001 From: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com> Date: Thu, 14 Aug 2025 11:40:43 +0300 Subject: [PATCH] Potential fix for code scanning alert no. 14: Insecure TLS configuration Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --- osscluster.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/osscluster.go b/osscluster.go index 6e57bef8..2a9f9182 100644 --- a/osscluster.go +++ b/osscluster.go @@ -329,14 +329,17 @@ func setupClusterQueryParams(u *url.URL, o *ClusterOptions) (*ClusterOptions, er if minVer < 0 || minVer > 65535 { return nil, fmt.Errorf("redis: invalid tls_min_version: %d (must be between 0 and 65535)", minVer) } - // Handle TLS version setting securely + // Always enforce TLS 1.2 as minimum if minVer == 0 { - // Don't set MinVersion, let Go use its secure default + o.TLSConfig.MinVersion = tls.VersionTLS12 } else if minVer < int(tls.VersionTLS12) { return nil, fmt.Errorf("redis: tls_min_version %d is insecure (minimum allowed is TLS 1.2: %d)", minVer, tls.VersionTLS12) } else { o.TLSConfig.MinVersion = uint16(minVer) } + } else { + // If not specified, always set minimum to TLS 1.2 + o.TLSConfig.MinVersion = tls.VersionTLS12 } if q.has("tls_max_version") { maxVer := q.int("tls_max_version")