CONTRIBUTING.md says a checklist with "checked without reading" or "AI
agent without human review" checked is closed, but nothing did it: #2138
stayed open with both boxes checked until a maintainer noticed. Close
such pull requests and issues when they are opened, edited or reopened.
The workflow reads only the body, so pull_request_target runs no code
from the pull request.
The test builds of main pass unstable-<date>.r<count>.<commit> to nfpm
as the package version. dpkg refuses it because a Debian version must
start with a digit, and pacman reports the package as corrupted because
the version contains a hyphen; the install check added in #2123 now
fails on the first push to main. Map such versions to the pre-release
0.0.0-unstable.<date>.r<count>.<commit>, which every packager accepts
and which sorts below any release. Release versions are unchanged, and
so are the file names and the version the binaries report.
The pull request build set EXTRA_LDFLAGS as a prefix of the go build
command and expanded ${EXTRA_LDFLAGS} in the same command, which the
shell does before the prefix assignment takes effect, so the flags were
always empty. The release build sets them in the job environment and
was not affected. Use the matrix value directly.
The 2.5.14 apk carried "provides = v2raya", which apk reads as a second
package conflicting with v2raya itself, so it could not be installed on
any Alpine release; nothing in the build noticed, and no package format
was ever installed by CI. Each packaging job now installs its packages
in containers of its own architecture, under QEMU where the runner
cannot run it, and runs v2raya --version: the apk on every architecture
(loong64 from Alpine's own minirootfs, which Docker's alpine image
lacks), the deb wherever Debian publishes an image, the rpm on amd64
and arm64, the Arch package on amd64. A change under install/nfpm or
install/universal now triggers the test build that packages them.
loong64 builds with cgo for mattn/go-sqlite3, and zig targeted
loongarch64-linux-gnu, so since 2.5.14 both binaries were linked
dynamically against glibc (interpreter
/lib64/ld-linux-loongarch-lp64d.so.1). The Alpine loongarch64 package
installed but neither binary could start on musl. Target musl and link
statically instead, so the binaries run on glibc and musl systems
alike. -linkmode=external makes the core, which has no cgo package of
its own, go through zig as well; with the internal linker it cannot
resolve the libc symbols of a static build.
Recent pull requests left the "Submitted and answered for by" line
filled in by an assistant or dropped, kept a commit that a later
commit reverted, and described changes their diff no longer had.
CONTRIBUTING.md also told contributors to run "the checks CI runs",
but CI runs neither go vet nor go test, and it named Go 1.26 while
core/ needs 1.27.
- CONTRIBUTING.md: Go 1.27; say which checks CI runs; squash a commit that undoes part of an earlier one; a bug fix
comes with a failing test or a reproduced failure; check the title,
description and messages against the diff; the sign-off line and the
boxes are the contributor's.
- AGENTS.md: ask before changing behaviour that may be intentional; a
check that ran nothing proves nothing; leave the sign-off line and
the human's boxes alone.
- Pull request templates: the sign-off line is required and written by
the contributor.
_install_zig.yml was declared as a reusable workflow but called from a
step, and a step-level uses only accepts an action, so the workflows
failed to validate. A job-level workflow call cannot help here either,
because Zig has to be on PATH in the same job as the build.
Move the install into .github/actions/install-zig, which pins the Zig
version itself and keeps both call sites on a single step.
The fpm invocation and its four hand-written architecture tables give way
to nfpm driven by install/nfpm/v2raya.yaml: nfpm maps the Go architecture
onto the name each packager expects, and writes the packages straight to
their published file names, so the rename step goes away too.
The package file names and the architecture matrix stay as they were, and
an apk package is added for Alpine, which boots the OpenRC script instead
of a systemd unit.
after_install.sh and after_upgrade.sh were the fpm hooks; their only
caller is gone, and the nfpm config carries equivalent maintainer
scripts.
The repository had six markdown issue templates, no pull request template and
no guide, so a report rarely said which version it was and a pull request
rarely said what its author had run.
The issue templates become four GitHub forms, English and Chinese kept apart,
asking for the version and why it is not the latest, the system and install
method, the transparent proxy mode, the steps, the logs and the person who
answers for the report. Usage questions go to Discussions through config.yml,
and blank issues are off. The pull request template, also in two languages,
asks for the change in the author's own words, what was executed and observed,
and a checklist of what the review expects; two of its boxes are true only of
someone who checked the list without reading it, or of an agent submitting
without human review, and checking either one closes the pull request.
CONTRIBUTING.md says where the code lives, what to run before opening a pull
request, that all six locales change together and that no AI attribution goes
into the history. AGENTS.md tells an assistant the same in its own terms, with
the traps that cost a review round: the web files the service embeds, the
locale and documentation directories that are named differently, the escaped
@ in a locale string, the Material colour and type tokens, and what in core/
belongs to v2rayA rather than to xray-core.
The Release_to_AUR job of _release.yml moves to _release_aur.yml (workflow_call,
input tag); the release calls it as before, after GitHub_Release and only with
publish_downstream. release_aur.yml runs it alone from workflow_dispatch, for the
case where the release went through and only the AUR step failed, as with 2.5.5.
833af7dc replaced 'git add .SRCINFO .INSTALL && git commit -a' with 'git add -A',
which also staged the installer_archlinux_*.pkg.tar.zst that updpkgsums downloads
into aur/v2raya-bin; the AUR hook rejected the 2.5.5 push (maximum blob size
488.28KiB exceeded). 'git add -u' stages the PKGBUILD and .SRCINFO changes and
the .INSTALL deletion, and nothing new.
Strings that still named v2ray-core, "v2ray / xray" or a wiki: six locales
(the core is v2raya_core; the invalid-service message, the SS plugin help,
the transparent-proxy hint, the TUN example, the custom inbound tag hint),
the --v2ray-bin, --core-startup-timeout and --plugin-manager descriptions
and their copies in the OpenRC confd files (the plugin manager is called
with --stage=parse|configuration, --link and --v2raya-confdir, not with
life-cycle stages), two comments that forbade or excused the current design,
the package descriptions that listed SSR, the AUR Go minimum (go.mod says
1.26), the systemd Documentation= and the installer's shortcut that pointed
at the wiki and the docs site, and the README sentence on network requests,
which left out the weekly release check and the NTP query on VMess failure.
copyfile, the empty ports/ss.go stub, parseDnsAddr and DnsRouting (the DNS
config is generated for the core's module now), the Inter font and the
switch-menu icon of the old GUI, the docs-site dispatch workflow (the site is
retired; the docs are in the app), the unused v2ray_arch in the docker helper,
the root .gitignore rule for a web directory that moved, and the .dockerignore
patterns for binary and test names that no longer exist. The skipped
TestFillEmpty asserts what FillEmpty does instead of what it once did.
A daily job lists open issues not updated for 60 days, except those labeled
notice or enhancement, and closes up to 100 of them as not planned with a
comment; there are 220 such issues today, the oldest from 2024.
A read of the tree for home-grown code that a dependency or the platform
covers. Each item names what replaces it.
- IPv4 CIDR membership was a binary-string trie (infra/dataStructure/trie)
fed with CIDRs rendered as bit strings; net.IPNet.Contains, which the
same file already used for IPv6, does it. The trie package is gone.
- The response replay cache was an LRU with its own linked list, indexes
and timeout strategy (infra/dataStructure/lru), of which one fixed-size
instance existed; hashicorp/golang-lru/v2, already in go.mod, is that
cache, typed. go mod tidy also dropped go-nanoid, which nothing imported.
- The HTTP client for subscription updates through the local proxy carried
a CONNECT dialer of its own (pkg/util/proxyWithHttp); http.Transport's
Proxy handles socks5:// and http:// URLs, resolves hostnames on the
SOCKS proxy and uses CONNECT for https. Verified on the VM: a
subscription update succeeds in both "pac" and "proxy" modes.
- core/dns/qtype.go listed nine type names in two switches before falling
back to miekg/dns tables that contain the same names; dns.Type.String
and dns.StringToType are the tables.
- The GUI tracked prefers-color-scheme with its own media query and
toggled a theme-dark class nothing reads any more; Vuetify's "system"
theme follows the OS itself. Verified in headless Chrome: auto follows
the OS in both directions, an explicit choice overrides it.
- The AUR packages carried .INSTALL hooks whose only content was a
coloured "Completed!" banner, duplicated in the deb/rpm after-install
scripts; pacman and apt report that themselves. The hooks are gone, the
release workflow stops copying them, and after_install/after_upgrade
keep only daemon-reload and the restart.
- The tap release job downloaded eight artifacts in eight steps;
actions/download-artifact takes a pattern with merge-multiple.
Three service packages outside the executable's dependency graph
(common/antiPollution, pkg/util/gopeed, kernel/vmessInfo), a blank
import of miekg/dns the core already imports, the --core-type flag no
code read, the PutAccount handler whose route was commented out, two GUI
API wrappers without a caller, two .SRCINFO files the release regenerates
and an unreferenced runit sample. The workflow path filters watched a
root go.mod that does not exist and the PR build skipped core/.
build.sh and build.ps1 each built the GUI, the core and the service
their own way, and nothing in the repository ran them; build.sh passed a
with_gvisor tag no source file declares. build.sh now runs the same
commands as _build_web.yml and _build_binaries.yml, takes the version as
an argument or from git describe, and stops at the first failing step;
build.ps1 is the same sequence for PowerShell.
release_main.yml and beta_release_main.yml duplicated every release job
and had drifted (the beta looked the release up in a hard-coded
repository). Both now call _release.yml with the tag, a prerelease flag
and whether to publish to the downstream package channels.
The toolchain of the rewrite: Vite with vite-plugin-pwa (autoUpdate,
/api/ never cached), vue-tsc, ESLint's flat config, Vitest with
happy-dom and a mount helper, an i18n check and a gzip size gate in CI,
Red Hat Text self-hosted under /static/fonts.
The binaries workflow, the PR workflow and build.ps1 no longer pass
-tags tinytun; there is nothing behind the tag. The Windows installer
takes wintun.dll from the official 0.14.1 package, pinned by hash, one
DLL per architecture, and deletes a tinytun.exe an earlier installer left
in the application's bin directory. The README states what the built-in
TUN does and its known limitation on Windows and macOS.
The vendored core/xray submodule is dropped. xray-core is now pinned via a
go mod pseudo-version resolving to v26.7.28 (commit 5ca6f4b7); v26 tags are
not directly resolvable because Xray's module path lacks the /v26 suffix, so
the pin must be made by commit hash. CI workflows and the AUR PKGBUILD no
longer need "submodules: recursive" / "git submodule update".
The juicity and tuic outbounds are ported from softwind to
github.com/daeuniverse/outbound (temporarily replaced with an olicesx fork
pending sticky-ip support):
- Dialer calls use DialContext; the network string is decoded with
netproxy.ParseMagicNetwork instead of a "udp" prefix check, since it may
be binary-encoded via netproxy.MagicNetwork.
- A packetConnAdapter wraps xray's UDP dial result: outbound asserts the
underlay conn to netproxy.PacketConn whose ReadFrom/WriteTo signatures
(netip.AddrPort / string) differ from net.PacketConn, while xray returns
*internet.PacketConnWrapper.
The <<< here-string appends an extra newline to the key file, which can
corrupt OpenSSH private key format and cause 'Bad passphrase' errors.
printf writes the exact content of the variable without modification.