From aa38fa6ba641d1656b3a62121bd72b6c5e93d153 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Krupa=20=28paulfantom=29?= <pawel@krupa.net.pl>
Date: Sun, 10 Apr 2022 16:22:25 +0200
Subject: [PATCH] postgres_mixin/alerts: change severity to "warning"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Changing severity to align with mixin recommendations from https://github.com/monitoring-mixins/docs#guidelines-for-alert-names-labels-and-annotations

Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
---
 postgres_mixin/alerts/postgres.libsonnet | 68 +++++++++++++++++++-----
 1 file changed, 56 insertions(+), 12 deletions(-)

diff --git a/postgres_mixin/alerts/postgres.libsonnet b/postgres_mixin/alerts/postgres.libsonnet
index 29e33923..d70f669d 100644
--- a/postgres_mixin/alerts/postgres.libsonnet
+++ b/postgres_mixin/alerts/postgres.libsonnet
@@ -10,10 +10,16 @@
               description: '{{ $labels.instance }} is exceeding the currently configured maximum Postgres connection limit (current value: {{ $value }}s). Services may be degraded - please take immediate action (you probably need to increase max_connections in the Docker image and re-deploy.',
               summary: '{{ $labels.instance }} has maxed out Postgres connections.',
             },
-            expr: 'sum(pg_stat_activity_count) by (instance) >= sum(pg_settings_max_connections) by (instance) - sum(pg_settings_superuser_reserved_connections) by (instance)',
+            expr: |||
+              sum by (instance) (pg_stat_activity_count{%(postgresExporterSelector)s})
+              >=
+              sum by (instance) (pg_settings_max_connections{%(postgresExporterSelector)s})
+              -
+              sum by (instance) (pg_settings_superuser_reserved_connections{%(postgresExporterSelector)s})
+            ||| % $._config,
             'for': '1m',
             labels: {
-              severity: 'email',
+              severity: 'warning',
             },
           },
           {
@@ -22,10 +28,18 @@
               description: '{{ $labels.instance }} is exceeding 80% of the currently configured maximum Postgres connection limit (current value: {{ $value }}s). Please check utilization graphs and confirm if this is normal service growth, abuse or an otherwise temporary condition or if new resources need to be provisioned (or the limits increased, which is mostly likely).',
               summary: '{{ $labels.instance }} is over 80% of max Postgres connections.',
             },
-            expr: 'sum(pg_stat_activity_count) by (instance) > (sum(pg_settings_max_connections) by (instance) - sum(pg_settings_superuser_reserved_connections) by (instance)) * 0.8',
+            expr: |||
+              sum by (instance) (pg_stat_activity_count{%(postgresExporterSelector)s})
+              >
+              (
+                sum by (instance) (pg_settings_max_connections{%(postgresExporterSelector)s})
+                -
+                sum by (instance) (pg_settings_superuser_reserved_connections{%(postgresExporterSelector)s})
+              ) * 0.8
+            ||| % $._config,
             'for': '10m',
             labels: {
-              severity: 'email',
+              severity: 'warning',
             },
           },
           {
@@ -34,10 +48,10 @@
               description: '{{ $labels.instance }} is rejecting query requests from the exporter, and thus probably not allowing DNS requests to work either. User services should not be effected provided at least 1 node is still alive.',
               summary: 'PostgreSQL is not processing queries: {{ $labels.instance }}',
             },
-            expr: 'pg_up != 1',
+            expr: 'pg_up{%(postgresExporterSelector)s} != 1' % $._config,
             'for': '1m',
             labels: {
-              severity: 'email',
+              severity: 'warning',
             },
           },
           {
@@ -46,10 +60,16 @@
               description: 'PostgreSQL high number of slow queries {{ $labels.cluster }} for database {{ $labels.datname }} with a value of {{ $value }} ',
               summary: 'PostgreSQL high number of slow on {{ $labels.cluster }} for database {{ $labels.datname }} ',
             },
-            expr: 'avg(rate(pg_stat_activity_max_tx_duration{datname!~"template.*"}[2m])) by (datname) > 2 * 60',
+            expr: |||
+              avg(
+                rate by (datname) (
+                  pg_stat_activity_max_tx_duration{datname!~"template.*",%(postgresExporterSelector)s}[2m]
+                )
+              ) > 2 * 60
+            ||| % $._config,
             'for': '2m',
             labels: {
-              severity: 'email',
+              severity: 'warning',
             },
           },
           {
@@ -58,10 +78,20 @@
               description: 'PostgreSQL high number of queries per second on {{ $labels.cluster }} for database {{ $labels.datname }} with a value of {{ $value }}',
               summary: 'PostgreSQL high number of queries per second {{ $labels.cluster }} for database {{ $labels.datname }}',
             },
-            expr: 'avg(irate(pg_stat_database_xact_commit{datname!~"template.*"}[5m]) + irate(pg_stat_database_xact_rollback{datname!~"template.*"}[5m])) by (datname) > 10000',
+            expr: |||
+              avg by (datname) (
+                irate(
+                  pg_stat_database_xact_commit{datname!~"template.*",%(postgresExporterSelector)s}[5m]
+                )
+                +
+                irate(
+                  pg_stat_database_xact_rollback{datname!~"template.*",%(postgresExporterSelector)s}[5m]
+                )
+              ) > 10000
+            ||| % $._config,
             'for': '5m',
             labels: {
-              severity: 'email',
+              severity: 'warning',
             },
           },
           {
@@ -70,10 +100,24 @@
               description: 'PostgreSQL low on cache hit rate on {{ $labels.cluster }} for database {{ $labels.datname }} with a value of {{ $value }}',
               summary: 'PostgreSQL low cache hit rate on {{ $labels.cluster }} for database {{ $labels.datname }}',
             },
-            expr: 'avg(rate(pg_stat_database_blks_hit{datname!~"template.*"}[5m]) / (rate(pg_stat_database_blks_hit{datname!~"template.*"}[5m]) + rate(pg_stat_database_blks_read{datname!~"template.*"}[5m]))) by (datname) < 0.98',
+            expr: |||
+              avg by (datname) (
+                rate(pg_stat_database_blks_hit{datname!~"template.*",%(postgresExporterSelector)s}[5m])
+                /
+                (
+                  rate(
+                    pg_stat_database_blks_hit{datname!~"template.*",%(postgresExporterSelector)s}[5m]
+                  )
+                  +
+                  rate(
+                    pg_stat_database_blks_read{datname!~"template.*",%(postgresExporterSelector)s}[5m]
+                  )
+                )
+              ) < 0.98
+            ||| % $._config,
             'for': '5m',
             labels: {
-              severity: 'email',
+              severity: 'warning',
             },
           },
         ],