prometheus/postgres_exporter
1
0
Fork 0
mirror of https://github.com/prometheus-community/postgres_exporter.git synced 2025-08-12 14:02:47 +03:00
Code Activity

Allow the redacted DSN logging to actually fire (DSN was never logged).

Browse Source 
The DSN parsing code failed to ever detect a URL like DSN, and as such never
logged anything.
This commit is contained in:
Will Rouesnel
2017-08-04 00:01:05 +10:00
parent c692b4e76a
commit 23f4af2354
2 changed files with 25 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
postgres_exporter_integration_test.go
View File

@@ -48,7 +48,6 @@ func (s *IntegrationSuite) TestAllNamespacesReturnResults(c *C) {
}
}()
// Open a database connection
db, err := sql.Open("postgres", s.e.dsn)
c.Assert(db, NotNil)
@@ -75,8 +74,9 @@ func (s *IntegrationSuite) TestAllNamespacesReturnResults(c *C) {
}
}
// TestInvalidDsnDoesntCrash tests that specifying an invalid DSN doesn't crash the exporter.
// https://github.com/wrouesnel/postgres_exporter/issues/93
// TestInvalidDsnDoesntCrash tests that specifying an invalid DSN doesn't crash
// the exporter. Related to https://github.com/wrouesnel/postgres_exporter/issues/93
// although not a replication of the scenario.
func (s *IntegrationSuite) TestInvalidDsnDoesntCrash(c *C) {
// Setup a dummy channel to consume metrics
ch := make(chan prometheus.Metric, 100)
@@ -85,6 +85,13 @@ func (s *IntegrationSuite) TestInvalidDsnDoesntCrash(c *C) {
}
}()
exporter := NewExporter("an invalid dsn", *queriesPath)
// Send a bad DSN
exporter := NewExporter("invalid dsn", *queriesPath)
c.Assert(exporter, NotNil)
exporter.scrape(ch)
}
// Send a DSN to a non-listening port.
exporter = NewExporter("postgresql://nothing:nothing@127.0.0.1:1/nothing", *queriesPath)
c.Assert(exporter, NotNil)
exporter.scrape(ch)
}