You've already forked mysqld_exporter
mirror of
https://github.com/prometheus/mysqld_exporter.git
synced 2025-07-30 06:43:05 +03:00
Allow empty passwords
Empty passwords are allowed for UNIX socket connections and when using TLS auth. Fixes: https://github.com/prometheus/mysqld_exporter/issues/686 Signed-off-by: SuperQ <superq@gmail.com>
This commit is contained in:
@ -167,9 +167,6 @@ func (m MySqlConfig) validateConfig() error {
|
||||
if m.User == "" {
|
||||
return fmt.Errorf("no user specified in section or parent")
|
||||
}
|
||||
if m.Password == "" {
|
||||
return fmt.Errorf("no password specified in section or parent")
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
@ -130,12 +130,14 @@ func TestValidateConfig(t *testing.T) {
|
||||
Config: &Config{},
|
||||
}
|
||||
os.Clearenv()
|
||||
err := c.ReloadConfig("testdata/missing_password.cnf", "localhost:3306", "", true, log.NewNopLogger())
|
||||
convey.So(
|
||||
err,
|
||||
convey.ShouldResemble,
|
||||
fmt.Errorf("no configuration found"),
|
||||
)
|
||||
if err := c.ReloadConfig("testdata/missing_password.cnf", "localhost:3306", "", true, log.NewNopLogger()); err != nil {
|
||||
t.Error(err)
|
||||
}
|
||||
|
||||
cfg := c.GetConfig()
|
||||
section := cfg.Sections["client"]
|
||||
convey.So(section.User, convey.ShouldEqual, "abc")
|
||||
convey.So(section.Password, convey.ShouldEqual, "")
|
||||
})
|
||||
}
|
||||
|
||||
|
Reference in New Issue
Block a user