prometheus/mysqld_exporter
1
0
Fork 0
mirror of https://github.com/prometheus/mysqld_exporter.git synced 2025-07-28 19:21:58 +03:00
Code Activity

fix innodb_metrics for mariadb 10.5+ (fixes #494) (#523)

Browse Source 
* determine column name for innodb_metrics before
querying
adds support more mariadb 10.4+, fixes 494

Signed-off-by: Mike <maemigh@gmail.com>
This commit is contained in:
Mike
2021-04-08 21:46:13 +09:00
committed by GitHub
parent 3381d9c187
commit 662d1a17f7
3 changed files with 39 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
collector/info_schema_innodb_metrics.go
View File

@ -18,6 +18,8 @@ package collector
import (
"context"
"database/sql"
"errors"
"fmt"
"regexp"
"github.com/go-kit/kit/log"
@ -25,13 +27,20 @@ import (
"github.com/prometheus/client_golang/prometheus"
)
const infoSchemaInnodbMetricsEnabledColumnQuery = `
SELECT
column_name
FROM information_schema.columns
WHERE table_name = 'INNODB_METRICS'
AND column_name IN ('status', 'enabled')
`
const infoSchemaInnodbMetricsQuery = `
SELECT
name, subsystem, type, comment,
count
FROM information_schema.innodb_metrics
WHERE status = 'enabled'
`
WHERE ` + "`%s` = '%s'"
// Metrics descriptors.
var (
@ -83,7 +92,24 @@ func (ScrapeInnodbMetrics) Version() float64 {
// Scrape collects data from database connection and sends it over channel as prometheus metric.
func (ScrapeInnodbMetrics) Scrape(ctx context.Context, db *sql.DB, ch chan<- prometheus.Metric, logger log.Logger) error {
innodbMetricsRows, err := db.QueryContext(ctx, infoSchemaInnodbMetricsQuery)
var enabledColumnName string
var query string
err := db.QueryRowContext(ctx, infoSchemaInnodbMetricsEnabledColumnQuery).Scan(&enabledColumnName)
if err != nil {
return err
}
switch enabledColumnName {
case "STATUS":
query = fmt.Sprintf(infoSchemaInnodbMetricsQuery, "status", "enabled")
case "ENABLED":
query = fmt.Sprintf(infoSchemaInnodbMetricsQuery, "enabled", "1")
default:
return errors.New("Couldn't find column STATUS or ENABLED in innodb_metrics table.")
}
innodbMetricsRows, err := db.QueryContext(ctx, query)
if err != nil {
return err
}