1
0
mirror of https://github.com/prometheus/mysqld_exporter.git synced 2025-07-30 06:43:05 +03:00

Fix minor golint issues.

This commit is contained in:
Ben Kochie
2016-04-13 23:17:22 +02:00
parent 5599062e12
commit 512dce7d49
6 changed files with 23 additions and 18 deletions

View File

@ -30,6 +30,7 @@ var (
) )
) )
// ScrapeBinlogSize colects from `SHOW BINARY LOGS`.
func ScrapeBinlogSize(db *sql.DB, ch chan<- prometheus.Metric) error { func ScrapeBinlogSize(db *sql.DB, ch chan<- prometheus.Metric) error {
var logBin uint8 var logBin uint8
err := db.QueryRow(logbinQuery).Scan(&logBin) err := db.QueryRow(logbinQuery).Scan(&logBin)

View File

@ -1,4 +1,4 @@
// Scrape `SHOW ENGINE TOKUDB STATUS` // Scrape `SHOW ENGINE TOKUDB STATUS`.
package collector package collector
@ -34,6 +34,7 @@ func sanitizeTokudbMetric(metricName string) string {
return metricName return metricName
} }
// ScrapeEngineTokudbStatus scrapes from `SHOW ENGINE TOKUDB STATUS`.
func ScrapeEngineTokudbStatus(db *sql.DB, ch chan<- prometheus.Metric) error { func ScrapeEngineTokudbStatus(db *sql.DB, ch chan<- prometheus.Metric) error {
tokudbRows, err := db.Query(engineTokudbStatusQuery) tokudbRows, err := db.Query(engineTokudbStatusQuery)
if err != nil { if err != nil {

View File

@ -1,4 +1,4 @@
// Scrape 'SHOW GLOBAL STATUS' // Scrape `SHOW GLOBAL STATUS`.
package collector package collector
@ -58,6 +58,7 @@ var (
) )
) )
// ScrapeGlobalStatus collects from `SHOW GLOBAL STATUS`.
func ScrapeGlobalStatus(db *sql.DB, ch chan<- prometheus.Metric) error { func ScrapeGlobalStatus(db *sql.DB, ch chan<- prometheus.Metric) error {
globalStatusRows, err := db.Query(globalStatusQuery) globalStatusRows, err := db.Query(globalStatusQuery)
if err != nil { if err != nil {

View File

@ -1,4 +1,4 @@
// Scrape `SHOW GLOBAL VARIABLES` // Scrape `SHOW GLOBAL VARIABLES`.
package collector package collector
@ -16,6 +16,7 @@ const (
globalVariablesQuery = `SHOW GLOBAL VARIABLES` globalVariablesQuery = `SHOW GLOBAL VARIABLES`
) )
// ScrapeGlobalVariables collects from `SHOW GLOBAL VARIABLES`.
func ScrapeGlobalVariables(db *sql.DB, ch chan<- prometheus.Metric) error { func ScrapeGlobalVariables(db *sql.DB, ch chan<- prometheus.Metric) error {
globalVariablesRows, err := db.Query(globalVariablesQuery) globalVariablesRows, err := db.Query(globalVariablesQuery)
if err != nil { if err != nil {

View File

@ -1,4 +1,4 @@
// Scrape `SHOW SLAVE STATUS` // Scrape `SHOW SLAVE STATUS`.
package collector package collector
@ -19,6 +19,7 @@ const (
var slaveStatusQuerySuffixes = [3]string{" NONBLOCKING", " NOLOCK", ""} var slaveStatusQuerySuffixes = [3]string{" NONBLOCKING", " NOLOCK", ""}
// ScrapeSlaveStatus collects from `SHOW SLAVE STATUS`.
func ScrapeSlaveStatus(db *sql.DB, ch chan<- prometheus.Metric) error { func ScrapeSlaveStatus(db *sql.DB, ch chan<- prometheus.Metric) error {
var ( var (
slaveStatusRows *sql.Rows slaveStatusRows *sql.Rows

View File

@ -862,7 +862,7 @@ func scrapePerfEventsStatements(db *sql.DB, ch chan<- prometheus.Metric) error {
defer perfSchemaEventsStatementsRows.Close() defer perfSchemaEventsStatementsRows.Close()
var ( var (
schemaName, digest, digest_text string schemaName, digest, digestText string
count, queryTime, errors, warnings uint64 count, queryTime, errors, warnings uint64
rowsAffected, rowsSent, rowsExamined uint64 rowsAffected, rowsSent, rowsExamined uint64
tmpTables, tmpDiskTables uint64 tmpTables, tmpDiskTables uint64
@ -872,57 +872,57 @@ func scrapePerfEventsStatements(db *sql.DB, ch chan<- prometheus.Metric) error {
for perfSchemaEventsStatementsRows.Next() { for perfSchemaEventsStatementsRows.Next() {
if err := perfSchemaEventsStatementsRows.Scan( if err := perfSchemaEventsStatementsRows.Scan(
&schemaName, &digest, &digest_text, &count, &queryTime, &errors, &warnings, &rowsAffected, &rowsSent, &rowsExamined, &tmpTables, &tmpDiskTables, &sortMergePasses, &sortRows, &noIndexUsed, &schemaName, &digest, &digestText, &count, &queryTime, &errors, &warnings, &rowsAffected, &rowsSent, &rowsExamined, &tmpTables, &tmpDiskTables, &sortMergePasses, &sortRows, &noIndexUsed,
); err != nil { ); err != nil {
return err return err
} }
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsDesc, prometheus.CounterValue, float64(count), performanceSchemaEventsStatementsDesc, prometheus.CounterValue, float64(count),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsTimeDesc, prometheus.CounterValue, float64(queryTime)/picoSeconds, performanceSchemaEventsStatementsTimeDesc, prometheus.CounterValue, float64(queryTime)/picoSeconds,
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsErrorsDesc, prometheus.CounterValue, float64(errors), performanceSchemaEventsStatementsErrorsDesc, prometheus.CounterValue, float64(errors),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsWarningsDesc, prometheus.CounterValue, float64(warnings), performanceSchemaEventsStatementsWarningsDesc, prometheus.CounterValue, float64(warnings),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsRowsAffectedDesc, prometheus.CounterValue, float64(rowsAffected), performanceSchemaEventsStatementsRowsAffectedDesc, prometheus.CounterValue, float64(rowsAffected),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsRowsSentDesc, prometheus.CounterValue, float64(rowsSent), performanceSchemaEventsStatementsRowsSentDesc, prometheus.CounterValue, float64(rowsSent),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsRowsExaminedDesc, prometheus.CounterValue, float64(rowsExamined), performanceSchemaEventsStatementsRowsExaminedDesc, prometheus.CounterValue, float64(rowsExamined),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsTmpTablesDesc, prometheus.CounterValue, float64(tmpTables), performanceSchemaEventsStatementsTmpTablesDesc, prometheus.CounterValue, float64(tmpTables),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsTmpDiskTablesDesc, prometheus.CounterValue, float64(tmpDiskTables), performanceSchemaEventsStatementsTmpDiskTablesDesc, prometheus.CounterValue, float64(tmpDiskTables),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsSortMergePassesDesc, prometheus.CounterValue, float64(sortMergePasses), performanceSchemaEventsStatementsSortMergePassesDesc, prometheus.CounterValue, float64(sortMergePasses),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsSortRowsDesc, prometheus.CounterValue, float64(sortRows), performanceSchemaEventsStatementsSortRowsDesc, prometheus.CounterValue, float64(sortRows),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
ch <- prometheus.MustNewConstMetric( ch <- prometheus.MustNewConstMetric(
performanceSchemaEventsStatementsNoIndexUsedDesc, prometheus.CounterValue, float64(noIndexUsed), performanceSchemaEventsStatementsNoIndexUsedDesc, prometheus.CounterValue, float64(noIndexUsed),
schemaName, digest, digest_text, schemaName, digest, digestText,
) )
} }
return nil return nil