You've already forked alertmanager
mirror of
https://github.com/prometheus/alertmanager.git
synced 2026-10-24 20:39:28 +03:00
1193873419
Fix three bugs in the reload handler identified in #5103: 1. Use a buffered error channel (size 1) so the reloader goroutine never blocks if the HTTP client disconnects before reading the result. 2. Remove the incorrect `defer close(errc)` — the handler is the receiver, not the sender; closing from the receiver side could panic the sender. 3. Wrap both the enqueue (send to reloadCh) and the reply (receive from errc) in select statements that also listen on req.Context().Done(), so a client disconnect unblocks the handler at either stage. Fixes #5103 Signed-off-by: June Kim <kimjune01@gmail.com> Signed-off-by: Solomon Jacobs <solomonjacobs@protonmail.com>
78 lines
2.4 KiB
Go
78 lines
2.4 KiB
Go
// Copyright The Prometheus Authors
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package httpserver
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
_ "net/http/pprof" // Comment this line to disable pprof endpoint.
|
|
"path"
|
|
"strings"
|
|
|
|
"github.com/prometheus/client_golang/prometheus/promhttp"
|
|
"github.com/prometheus/common/route"
|
|
)
|
|
|
|
// Register registers handlers to serve files for automations.
|
|
func Register(r *route.Router, reloadCh chan<- chan error) {
|
|
r.Get("/metrics", promhttp.Handler().ServeHTTP)
|
|
|
|
r.Post("/-/reload", func(w http.ResponseWriter, req *http.Request) {
|
|
errc := make(chan error, 1)
|
|
|
|
select {
|
|
case reloadCh <- errc:
|
|
case <-req.Context().Done():
|
|
http.Error(w, req.Context().Err().Error(), http.StatusUnprocessableEntity)
|
|
return
|
|
}
|
|
|
|
select {
|
|
case err := <-errc:
|
|
if err != nil {
|
|
http.Error(w, fmt.Sprintf("failed to reload config: %s", err), http.StatusInternalServerError)
|
|
}
|
|
case <-req.Context().Done():
|
|
http.Error(w, req.Context().Err().Error(), http.StatusUnprocessableEntity)
|
|
}
|
|
})
|
|
|
|
r.Get("/-/healthy", func(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
fmt.Fprintf(w, "OK")
|
|
})
|
|
r.Head("/-/healthy", func(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
})
|
|
r.Get("/-/ready", func(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
fmt.Fprintf(w, "OK")
|
|
})
|
|
r.Head("/-/ready", func(w http.ResponseWriter, _ *http.Request) {
|
|
w.WriteHeader(http.StatusOK)
|
|
})
|
|
|
|
debugHandlerFunc := func(w http.ResponseWriter, req *http.Request) {
|
|
subpath := route.Param(req.Context(), "subpath")
|
|
req.URL.Path = path.Join("/debug", subpath)
|
|
// path.Join removes trailing slashes, but some pprof handlers expect them.
|
|
if strings.HasSuffix(subpath, "/") && !strings.HasSuffix(req.URL.Path, "/") {
|
|
req.URL.Path += "/"
|
|
}
|
|
http.DefaultServeMux.ServeHTTP(w, req)
|
|
}
|
|
r.Get("/debug/*subpath", debugHandlerFunc)
|
|
r.Post("/debug/*subpath", debugHandlerFunc)
|
|
}
|