mirror of
https://github.com/coturn/coturn.git
synced 2026-10-24 00:08:57 +03:00
fc8eb910fb
## Summary Fix OAuth TURN token handling : - Revalidate the presented access token on every Allocate and Refresh, even when the session already has a cached MAC key. - Track the token's absolute expiry and cap each response lifetime to the time still available. - Reject tokens with zero lifetime or timestamps outside the permitted clock-skew window, and reject empty or malformed AS-RS key material. ## Validation - macOS CMake build and CTest: 21/21 passed. - macOS TURN system scripts: core, configuration, mobility, multiplex peer, stateless nonce, IPv6 relay, and DTLS default passed. RFC 5780 skipped because a second loopback address was unavailable. - New OAuth end-to-end probe passed, including Refresh after expiry and malformed-key cases. - ASan fuzzing smoke tests passed for both local targets. - Linux CMake build and CTest: 20/20 passed. The OAuth probe and all required Linux system scripts passed, including RFC 5780 and IPv6 relay. - Packaged Debian Docker image Bats tests: 19 tests, 0 failures, 2 expected skips. - clang-format 15 check passed for every changed C/H file.
116 lines
3.6 KiB
C
116 lines
3.6 KiB
C
#include "apputils.h"
|
|
#include "ns_turn_msg.h"
|
|
|
|
#include <unity.h>
|
|
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
void setUp(void) {}
|
|
void tearDown(void) {}
|
|
|
|
static void test_decode_roundtrips_ascii(void) {
|
|
size_t out_len = 0;
|
|
unsigned char *out = base64_decode("Zm9vYmFy", 8, &out_len); /* "foobar" */
|
|
|
|
TEST_ASSERT_NOT_NULL(out);
|
|
TEST_ASSERT_EQUAL_size_t(6, out_len);
|
|
TEST_ASSERT_EQUAL_MEMORY("foobar", out, 6);
|
|
free(out);
|
|
}
|
|
|
|
/* Bytes with the high bit set are not valid base64 characters. They must be
|
|
looked up as unsigned indices into the 256-entry decoding table (where they
|
|
map to 0), not sign-extended to a negative offset that reads before it. */
|
|
static void test_decode_high_bit_bytes_are_not_oob(void) {
|
|
const char in[4] = {(char)0x80, (char)0xC0, (char)0xFF, (char)0x80};
|
|
size_t out_len = 0;
|
|
unsigned char *out = base64_decode(in, sizeof(in), &out_len);
|
|
|
|
TEST_ASSERT_NOT_NULL(out);
|
|
TEST_ASSERT_EQUAL_size_t(3, out_len);
|
|
TEST_ASSERT_EQUAL_UINT8(0, out[0]);
|
|
TEST_ASSERT_EQUAL_UINT8(0, out[1]);
|
|
TEST_ASSERT_EQUAL_UINT8(0, out[2]);
|
|
free(out);
|
|
}
|
|
|
|
static void test_decode_one_padding_char(void) {
|
|
size_t out_len = 0;
|
|
unsigned char *out = base64_decode("Zm8=", 4, &out_len); /* "fo" */
|
|
|
|
TEST_ASSERT_NOT_NULL(out);
|
|
TEST_ASSERT_EQUAL_size_t(2, out_len);
|
|
TEST_ASSERT_EQUAL_MEMORY("fo", out, 2);
|
|
free(out);
|
|
}
|
|
|
|
static void test_decode_two_padding_chars(void) {
|
|
size_t out_len = 0;
|
|
unsigned char *out = base64_decode("Zg==", 4, &out_len); /* "f" */
|
|
|
|
TEST_ASSERT_NOT_NULL(out);
|
|
TEST_ASSERT_EQUAL_size_t(1, out_len);
|
|
TEST_ASSERT_EQUAL_MEMORY("f", out, 1);
|
|
free(out);
|
|
}
|
|
|
|
/* Empty input must not read data[-1]/data[-2] when probing for padding. */
|
|
static void test_decode_empty_input_returns_null(void) {
|
|
size_t out_len = 123;
|
|
unsigned char *out = base64_decode("", 0, &out_len);
|
|
|
|
TEST_ASSERT_NULL(out);
|
|
TEST_ASSERT_EQUAL_size_t(0, out_len);
|
|
}
|
|
|
|
static void test_oauth_key_rejects_empty_and_malformed_material(void) {
|
|
oauth_key_data_raw raw = {0};
|
|
oauth_key_data data = {0};
|
|
oauth_key key = {0};
|
|
char error[128] = {0};
|
|
strcpy(raw.kid, "test");
|
|
strcpy(raw.as_rs_alg, "A256GCM");
|
|
|
|
convert_oauth_key_data_raw(&raw, &data);
|
|
TEST_ASSERT_FALSE(convert_oauth_key_data(&data, &key, error, sizeof(error)));
|
|
|
|
memset(raw.ikm_key, '!', 43);
|
|
raw.ikm_key[43] = '=';
|
|
raw.ikm_key[44] = 0;
|
|
convert_oauth_key_data_raw(&raw, &data);
|
|
TEST_ASSERT_EQUAL_size_t(0, data.ikm_key_size);
|
|
TEST_ASSERT_FALSE(convert_oauth_key_data(&data, &key, error, sizeof(error)));
|
|
}
|
|
|
|
static void test_oauth_key_requires_enough_bytes_for_algorithm(void) {
|
|
oauth_key_data_raw raw = {0};
|
|
oauth_key_data data = {0};
|
|
oauth_key key = {0};
|
|
char error[128] = {0};
|
|
strcpy(raw.kid, "test");
|
|
strcpy(raw.as_rs_alg, "A256GCM");
|
|
strcpy(raw.ikm_key, "MDEyMzQ1Njc4OWFiY2RlZg=="); /* 16 bytes */
|
|
|
|
convert_oauth_key_data_raw(&raw, &data);
|
|
TEST_ASSERT_EQUAL_size_t(16, data.ikm_key_size);
|
|
TEST_ASSERT_FALSE(convert_oauth_key_data(&data, &key, error, sizeof(error)));
|
|
|
|
strcpy(raw.as_rs_alg, "A128GCM");
|
|
convert_oauth_key_data_raw(&raw, &data);
|
|
TEST_ASSERT_TRUE(convert_oauth_key_data(&data, &key, error, sizeof(error)));
|
|
TEST_ASSERT_EQUAL_size_t(16, key.as_rs_key_size);
|
|
}
|
|
|
|
int main(void) {
|
|
UNITY_BEGIN();
|
|
RUN_TEST(test_decode_roundtrips_ascii);
|
|
RUN_TEST(test_decode_high_bit_bytes_are_not_oob);
|
|
RUN_TEST(test_decode_one_padding_char);
|
|
RUN_TEST(test_decode_two_padding_chars);
|
|
RUN_TEST(test_decode_empty_input_returns_null);
|
|
RUN_TEST(test_oauth_key_rejects_empty_and_malformed_material);
|
|
RUN_TEST(test_oauth_key_requires_enough_bytes_for_algorithm);
|
|
return UNITY_END();
|
|
}
|