mobi/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2025-12-06 07:41:18 +03:00
Code Activity

test: add buffer to prevent goroutine leak

Browse Source 
Signed-off-by: Ziheng Liu <lzhfromustc@gmail.com>
This commit is contained in:
Ziheng Liu
2020-02-25 17:13:25 -05:00
parent d706420b5d
commit c322af8019
22 changed files with 63 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
integration-cli/docker_cli_run_unix_test.go
View File

@@ -40,7 +40,7 @@ func (s *DockerSuite) TestRunRedirectStdout(c *testing.T) {
cmd.Stdout = tty
cmd.Stderr = tty
assert.NilError(c, cmd.Start())
ch := make(chan error)
ch := make(chan error, 1)
go func() {
ch <- cmd.Wait()
close(ch)
@@ -122,7 +122,7 @@ func (s *DockerSuite) TestRunAttachDetach(c *testing.T) {
_, err = cpty.Write([]byte{17})
assert.NilError(c, err)
ch := make(chan struct{})
ch := make(chan struct{}, 1)
go func() {
cmd.Wait()
ch <- struct{}{}
@@ -188,7 +188,7 @@ func (s *DockerSuite) TestRunAttachDetachFromFlag(c *testing.T) {
c.Fatal(err)
}
ch := make(chan struct{})
ch := make(chan struct{}, 1)
go func() {
cmd.Wait()
ch <- struct{}{}
@@ -304,7 +304,7 @@ func (s *DockerSuite) TestRunAttachDetachFromConfig(c *testing.T) {
c.Fatal(err)
}
ch := make(chan struct{})
ch := make(chan struct{}, 1)
go func() {
cmd.Wait()
ch <- struct{}{}
@@ -387,7 +387,7 @@ func (s *DockerSuite) TestRunAttachDetachKeysOverrideConfig(c *testing.T) {
c.Fatal(err)
}
ch := make(chan struct{})
ch := make(chan struct{}, 1)
go func() {
cmd.Wait()
ch <- struct{}{}
@@ -615,7 +615,7 @@ func (s *DockerSuite) TestRunWithInvalidPathforBlkioDeviceWriteIOps(c *testing.T
func (s *DockerSuite) TestRunOOMExitCode(c *testing.T) {
testRequires(c, memoryLimitSupport, swapMemorySupport, NotPpc64le)
errChan := make(chan error)
errChan := make(chan error, 1)
go func() {
defer close(errChan)
// memory limit lower than 8MB will raise an error of "device or resource busy" from docker-runc.