mobi/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2025-07-07 08:01:24 +03:00
Code Activity

Fix flaky test TestDaemonRestartRestoreBridgeNetwork

Browse Source 
It checked for "Bind for 0.0.0.0:80 failed: port is already
allocated". But, since commit d662091 ("portallocator: always
check for ports allocated for 0.0.0.0/::"), the message is
sometimes about ":::80".

Signed-off-by: Rob Murray <rob.murray@docker.com>
This commit is contained in:
Rob Murray
2025-06-13 10:53:22 +01:00
parent 5bbdb066d8
commit aac0260d21
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
integration-cli/docker_cli_network_unix_test.go
View File

@ -1691,8 +1691,8 @@ func (s *DockerDaemonSuite) TestDaemonRestartRestoreBridgeNetwork(t *testing.T)
// start a new container, trying to publish port 80:80 should fail
out, err := s.d.Cmd("run", "-p", "80:80", "-d", "busybox", "top")
if err == nil || !strings.Contains(out, "Bind for 0.0.0.0:80 failed: port is already allocated") {
t.Fatalf("80 port is allocated to old running container, it should failed on allocating to new container")
if err == nil || !strings.Contains(out, "port is already allocated") {
t.Fatalf("Expected 'port is already allocated', got err:%v out:%s", err, out)
}
// kill old running container and try to allocate again