mobi/moby
1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2025-07-30 18:23:29 +03:00
Code Activity

Merge pull request #18889 from aaronlehmann/v1-fallback-pull-all-tags

Browse Source 
Allow v1 protocol fallback when pulling all tags from a repository unknown to v2 registry
This commit is contained in:
Phil Estes
2016-01-05 16:20:04 -05:00
parent df9a3d1005 589a5226e7
commit 6c30931b06
3 changed files with 59 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
integration-cli/docker_cli_pull_test.go
View File

@ -56,7 +56,15 @@ func (s *DockerHubPullSuite) TestPullNonExistingImage(c *check.C) {
// the v2 protocol - but we should end up falling back to v1,
// which does return a 404.
c.Assert(out, checker.Contains, fmt.Sprintf("Error: image %s not found", e.Repo), check.Commentf("expected image not found error messages"))
// pull -a on a nonexistent registry should fall back as well
if !strings.ContainsRune(e.Alias, ':') {
out, err := s.CmdWithError("pull", "-a", e.Alias)
c.Assert(err, checker.NotNil, check.Commentf("expected non-zero exit status when pulling non-existing image: %s", out))
c.Assert(out, checker.Contains, fmt.Sprintf("Error: image %s not found", e.Repo), check.Commentf("expected image not found error messages"))
}
}
}
// TestPullFromCentralRegistryImplicitRefParts pulls an image from the central registry and verifies