mirror of
https://github.com/moby/moby.git
synced 2025-08-01 05:47:11 +03:00
add ability to publish range of ports
Closes #8899 Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
This commit is contained in:
committed by
Srini Brahmaroutu
parent
b2ab733c99
commit
2338a9cf5a
@ -2,6 +2,7 @@ package main
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"github.com/docker/docker/nat"
|
||||
"os"
|
||||
"os/exec"
|
||||
"testing"
|
||||
@ -102,6 +103,104 @@ func TestCreateHostConfig(t *testing.T) {
|
||||
logDone("create - hostconfig")
|
||||
}
|
||||
|
||||
func TestCreateWithPortRange(t *testing.T) {
|
||||
runCmd := exec.Command(dockerBinary, "create", "-p", "3300-3303:3300-3303/tcp", "busybox", "echo")
|
||||
out, _, _, err := runCommandWithStdoutStderr(runCmd)
|
||||
if err != nil {
|
||||
t.Fatal(out, err)
|
||||
}
|
||||
|
||||
cleanedContainerID := stripTrailingCharacters(out)
|
||||
|
||||
inspectCmd := exec.Command(dockerBinary, "inspect", cleanedContainerID)
|
||||
out, _, err = runCommandWithOutput(inspectCmd)
|
||||
if err != nil {
|
||||
t.Fatalf("out should've been a container id: %s, %v", out, err)
|
||||
}
|
||||
|
||||
containers := []struct {
|
||||
HostConfig *struct {
|
||||
PortBindings map[nat.Port][]nat.PortBinding
|
||||
}
|
||||
}{}
|
||||
if err := json.Unmarshal([]byte(out), &containers); err != nil {
|
||||
t.Fatalf("Error inspecting the container: %s", err)
|
||||
}
|
||||
if len(containers) != 1 {
|
||||
t.Fatalf("Unexpected container count. Expected 0, received: %d", len(containers))
|
||||
}
|
||||
|
||||
c := containers[0]
|
||||
if c.HostConfig == nil {
|
||||
t.Fatalf("Expected HostConfig, got none")
|
||||
}
|
||||
|
||||
if len(c.HostConfig.PortBindings) != 4 {
|
||||
t.Fatalf("Expected 4 ports bindings, got %d", len(c.HostConfig.PortBindings))
|
||||
}
|
||||
for k, v := range c.HostConfig.PortBindings {
|
||||
if len(v) != 1 {
|
||||
t.Fatalf("Expected 1 ports binding, for the port %s but found %s", k, v)
|
||||
}
|
||||
if k.Port() != v[0].HostPort {
|
||||
t.Fatalf("Expected host port %d to match published port %d", k.Port(), v[0].HostPort)
|
||||
}
|
||||
}
|
||||
|
||||
deleteAllContainers()
|
||||
|
||||
logDone("create - port range")
|
||||
}
|
||||
|
||||
func TestCreateWithiLargePortRange(t *testing.T) {
|
||||
runCmd := exec.Command(dockerBinary, "create", "-p", "1-65535:1-65535/tcp", "busybox", "echo")
|
||||
out, _, _, err := runCommandWithStdoutStderr(runCmd)
|
||||
if err != nil {
|
||||
t.Fatal(out, err)
|
||||
}
|
||||
|
||||
cleanedContainerID := stripTrailingCharacters(out)
|
||||
|
||||
inspectCmd := exec.Command(dockerBinary, "inspect", cleanedContainerID)
|
||||
out, _, err = runCommandWithOutput(inspectCmd)
|
||||
if err != nil {
|
||||
t.Fatalf("out should've been a container id: %s, %v", out, err)
|
||||
}
|
||||
|
||||
containers := []struct {
|
||||
HostConfig *struct {
|
||||
PortBindings map[nat.Port][]nat.PortBinding
|
||||
}
|
||||
}{}
|
||||
if err := json.Unmarshal([]byte(out), &containers); err != nil {
|
||||
t.Fatalf("Error inspecting the container: %s", err)
|
||||
}
|
||||
if len(containers) != 1 {
|
||||
t.Fatalf("Unexpected container count. Expected 0, received: %d", len(containers))
|
||||
}
|
||||
|
||||
c := containers[0]
|
||||
if c.HostConfig == nil {
|
||||
t.Fatalf("Expected HostConfig, got none")
|
||||
}
|
||||
|
||||
if len(c.HostConfig.PortBindings) != 65535 {
|
||||
t.Fatalf("Expected 65535 ports bindings, got %d", len(c.HostConfig.PortBindings))
|
||||
}
|
||||
for k, v := range c.HostConfig.PortBindings {
|
||||
if len(v) != 1 {
|
||||
t.Fatalf("Expected 1 ports binding, for the port %s but found %s", k, v)
|
||||
}
|
||||
if k.Port() != v[0].HostPort {
|
||||
t.Fatalf("Expected host port %d to match published port %d", k.Port(), v[0].HostPort)
|
||||
}
|
||||
}
|
||||
|
||||
deleteAllContainers()
|
||||
|
||||
logDone("create - large port range")
|
||||
}
|
||||
|
||||
// "test123" should be printed by docker create + start
|
||||
func TestCreateEchoStdout(t *testing.T) {
|
||||
runCmd := exec.Command(dockerBinary, "create", "busybox", "echo", "test123")
|
||||
|
Reference in New Issue
Block a user