mirror of
https://github.com/moby/moby.git
synced 2025-12-07 19:42:23 +03:00
Port 'docker images' to the engine API
Docker-DCO-1.1-Signed-off-by: Solomon Hykes <solomon@docker.com> (github: shykes)
This commit is contained in:
committed by
Victor Vieux
parent
6652416f4c
commit
17a806c8a0
@@ -14,10 +14,7 @@ func TestImageTagImageDelete(t *testing.T) {
|
||||
|
||||
srv := mkServerFromEngine(eng, t)
|
||||
|
||||
initialImages, err := srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
initialImages := getAllImages(eng, t)
|
||||
if err := eng.Job("tag", unitTestImageName, "utest", "tag1").Run(); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
@@ -30,52 +27,43 @@ func TestImageTagImageDelete(t *testing.T) {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
images, err := srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images := getAllImages(eng, t)
|
||||
|
||||
if len(images[0].RepoTags) != len(initialImages[0].RepoTags)+3 {
|
||||
t.Errorf("Expected %d images, %d found", len(initialImages)+3, len(images))
|
||||
nExpected := len(initialImages.Data[0].GetList("RepoTags")) + 3
|
||||
nActual := len(images.Data[0].GetList("RepoTags"))
|
||||
if nExpected != nActual {
|
||||
t.Errorf("Expected %d images, %d found", nExpected, nActual)
|
||||
}
|
||||
|
||||
if _, err := srv.ImageDelete("utest/docker:tag2", true); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
images, err = srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images = getAllImages(eng, t)
|
||||
|
||||
if len(images[0].RepoTags) != len(initialImages[0].RepoTags)+2 {
|
||||
t.Errorf("Expected %d images, %d found", len(initialImages)+2, len(images))
|
||||
nExpected = len(initialImages.Data[0].GetList("RepoTags")) + 2
|
||||
nActual = len(images.Data[0].GetList("RepoTags"))
|
||||
if nExpected != nActual {
|
||||
t.Errorf("Expected %d images, %d found", nExpected, nActual)
|
||||
}
|
||||
|
||||
if _, err := srv.ImageDelete("utest:5000/docker:tag3", true); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
images, err = srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images = getAllImages(eng, t)
|
||||
|
||||
if len(images[0].RepoTags) != len(initialImages[0].RepoTags)+1 {
|
||||
t.Errorf("Expected %d images, %d found", len(initialImages)+1, len(images))
|
||||
}
|
||||
nExpected = len(initialImages.Data[0].GetList("RepoTags")) + 1
|
||||
nActual = len(images.Data[0].GetList("RepoTags"))
|
||||
|
||||
if _, err := srv.ImageDelete("utest:tag1", true); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
images, err = srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images = getAllImages(eng, t)
|
||||
|
||||
if len(images) != len(initialImages) {
|
||||
t.Errorf("Expected %d image, %d found", len(initialImages), len(images))
|
||||
if images.Len() != initialImages.Len() {
|
||||
t.Errorf("Expected %d image, %d found", initialImages.Len(), images.Len())
|
||||
}
|
||||
}
|
||||
|
||||
@@ -250,10 +238,7 @@ func TestRmi(t *testing.T) {
|
||||
srv := mkServerFromEngine(eng, t)
|
||||
defer mkRuntimeFromEngine(eng, t).Nuke()
|
||||
|
||||
initialImages, err := srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
initialImages := getAllImages(eng, t)
|
||||
|
||||
config, hostConfig, _, err := docker.ParseRun([]string{unitTestImageID, "echo", "test"}, nil)
|
||||
if err != nil {
|
||||
@@ -308,13 +293,10 @@ func TestRmi(t *testing.T) {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
images, err := srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images := getAllImages(eng, t)
|
||||
|
||||
if len(images)-len(initialImages) != 2 {
|
||||
t.Fatalf("Expected 2 new images, found %d.", len(images)-len(initialImages))
|
||||
if images.Len()-initialImages.Len() != 2 {
|
||||
t.Fatalf("Expected 2 new images, found %d.", images.Len()-initialImages.Len())
|
||||
}
|
||||
|
||||
_, err = srv.ImageDelete(imageID, true)
|
||||
@@ -322,20 +304,17 @@ func TestRmi(t *testing.T) {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
images, err = srv.Images(false, "")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
images = getAllImages(eng, t)
|
||||
|
||||
if images.Len()-initialImages.Len() != 1 {
|
||||
t.Fatalf("Expected 1 new image, found %d.", images.Len()-initialImages.Len())
|
||||
}
|
||||
|
||||
if len(images)-len(initialImages) != 1 {
|
||||
t.Fatalf("Expected 1 new image, found %d.", len(images)-len(initialImages))
|
||||
}
|
||||
|
||||
for _, image := range images {
|
||||
if strings.Contains(unitTestImageID, image.ID) {
|
||||
for _, image := range images.Data {
|
||||
if strings.Contains(unitTestImageID, image.Get("ID")) {
|
||||
continue
|
||||
}
|
||||
if image.RepoTags[0] == "<none>:<none>" {
|
||||
if image.GetList("RepoTags")[0] == "<none>:<none>" {
|
||||
t.Fatalf("Expected tagged image, got untagged one.")
|
||||
}
|
||||
}
|
||||
@@ -359,39 +338,27 @@ func TestImagesFilter(t *testing.T) {
|
||||
t.Fatal(err)
|
||||
}
|
||||
|
||||
images, err := srv.Images(false, "utest*/*")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images := getImages(eng, t, false, "utest*/*")
|
||||
|
||||
if len(images[0].RepoTags) != 2 {
|
||||
if len(images.Data[0].GetList("RepoTags")) != 2 {
|
||||
t.Fatal("incorrect number of matches returned")
|
||||
}
|
||||
|
||||
images, err = srv.Images(false, "utest")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images = getImages(eng, t, false, "utest")
|
||||
|
||||
if len(images[0].RepoTags) != 1 {
|
||||
if len(images.Data[0].GetList("RepoTags")) != 1 {
|
||||
t.Fatal("incorrect number of matches returned")
|
||||
}
|
||||
|
||||
images, err = srv.Images(false, "utest*")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images = getImages(eng, t, false, "utest*")
|
||||
|
||||
if len(images[0].RepoTags) != 1 {
|
||||
if len(images.Data[0].GetList("RepoTags")) != 1 {
|
||||
t.Fatal("incorrect number of matches returned")
|
||||
}
|
||||
|
||||
images, err = srv.Images(false, "*5000*/*")
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
images = getImages(eng, t, false, "*5000*/*")
|
||||
|
||||
if len(images[0].RepoTags) != 1 {
|
||||
if len(images.Data[0].GetList("RepoTags")) != 1 {
|
||||
t.Fatal("incorrect number of matches returned")
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user