1
0
mirror of https://github.com/moby/moby.git synced 2025-08-01 05:47:11 +03:00

Make daemonbuilder.Docker leaner.

Currently builder.Backend is implemented by daemonbuilder.Docker{} for
the daemon. This registration happens in the API/server code. However,
this is too implementation specific. Ideally we should be able to specify
that docker daemon (or any other) is implementing the Backend and abstract
the implementation details. So we should remove package daemonbuilder
dependency in build_routes.go

With this change, daemonbuilder.Docker is nothing more than the daemon.
A follow on change will remove the daemonbuilder package and move relevant
methods under daemon, so that API only knows about the backend.

Also cleanup code in api/client/build.go. docker cli always performs build
context tar download for remoteURLs and sends an empty remoteContext. So
remove relevant dead code.

Signed-off-by: Anusha Ragunathan <anusha@docker.com>
This commit is contained in:
Anusha Ragunathan
2016-01-12 14:38:55 -08:00
parent 3720fbfb35
commit 14215ed5a1
6 changed files with 27 additions and 42 deletions

View File

@ -67,7 +67,8 @@ type Builder struct {
allowedBuildArgs map[string]bool // list of build-time args that are allowed for expansion/substitution and passing to commands in 'run'.
// TODO: remove once docker.Commit can receive a tag
id string
id string
Output io.Writer
}
// NewBuilder creates a new Dockerfile builder from an optional dockerfile and a Config.