minio/mc
1
0
Fork 0
mirror of https://github.com/minio/mc.git synced 2025-11-13 12:22:45 +03:00
Code Activity
3,433 Commits 6 Branches 322 Tags
75a36b4831c35ebf7cb15ca9e617f057c7729b6f
Commit Graph

34 Commits

Author SHA1 Message Date
Harshavardhana
59ef9fe468 Support SSE without keys (#2626) 2019-01-04 11:56:43 -08:00
Harshavardhana
cb4f46854b Fix command line names and documentation (#2602) 2018-11-19 17:19:53 -08:00
Harshavardhana
12627c35e4 Fix parallel upload performance issues (#2521) 
Tested by transferring 29GiB data, around 246569 files
over 100Gig network.

- master branch
```
time mc mirror /root myminio/testbucket/
real	2m10s
```

- after changes
```
time mc mirror /root myminio/testbucket/
real	1m2s
```

By default runtime.NumCPU() workers are started.
 2018-08-30 22:31:08 +05:30
Harshavardhana
bc756e3dbd Fix cp crash when resuming from session (#2520) 
We should make sure to handle errors properly
when reading from the session and also parsing.

Current master ignores all these situations
which leads to crash, this PR handles this to avoid
nil pointer crashes.
 2018-08-27 12:03:40 -07:00
Harshavardhana
70dcf20d74 Pass down encrypt-key handling across command validators (#2483) 
Currently even if the command supports encrypted objects,
the syntax verification would fail on them in certain
cases. Since syntax validation of source/targets doesn't
use the parsed encrypt key pairs.  This PR fixes this
behavior.
 2018-07-12 11:13:51 -07:00
Anis Elleuch
d566905d7a Properly shutdown parallel copy in cp command (#2448) 2018-05-31 12:38:22 -07:00
Anis Elleuch
1ccf40d1e5 Properly stop parallel work in mirror/cp when the user clicks on Ctrl-C (#2437) 2018-04-25 11:55:07 -07:00
Anis Elleuch
45b32d3985 errors: Add missing ending dot in error & fatal messages (#2418) 2018-03-23 12:22:55 +05:30
poornas
fe82b0381c change encryption key parsing to allow spaces in sse-c key (#2408) 
Also vendoring in minio-go updates
 2018-03-14 02:47:14 -07:00
poornas
0ede95b65e add encrypt option to cp, mirror,pipe,stat, cat and rm commands (#2400) 2018-03-08 17:18:41 +05:30
Nitish Tiwari
ea580b0b65 Add storage-class support (#2403) 
This PR adds storage-class support for mc cp and mirror command.
Storage class values are passed via the -storage-class or
--sc flag.

Fixes #1859
 2018-03-03 10:28:53 -08:00
A. Elleuch
017dddef97 Add --newer-than & --older-than flags (#2142) 
Use --newer-than & --older-than to select newer or older files
in copy, remove and mirroring operations.
 2018-02-01 10:32:22 -08:00
A. Elleuch
5ddf9728f8 Parallelize upload/remove in cp/mirror commands (#2289) 
This PR removes --parallel flag and implements a dynamic way of adding
threads to accelerate mirror/cp command.

After the calculation of objects that need to be copied/removed, mc
sends tasks (upload/remove) to a parallel manager which monitors the
progress of tasks and decide to allocate more threads to it to
accelerate the overall work.

This is very useful when we copy/mirror many relatively small files.
 2017-12-07 16:20:34 -08:00
poornas
275db95170 mc: Remove MC_MULTIPART_THREADS env variable (#2326) 
Remove this var as PR#2289 will manage threads automatically based on
workload to speed up mc cp/mirror operations.
 2017-12-06 09:30:20 -08:00
poornas
a86080a0b7 Add context in Put api call for cp/mirror. (#2291) 2017-10-20 13:50:35 -07:00
A. Elleuch
8f38471e29 fix: Correct some cp/mirror help indentations (#2268) 2017-10-06 09:35:44 -07:00
poornas
224e602e59 Allow multipart threads to be configured via environment variable (#2254) 2017-10-02 19:45:08 -07:00
chibiegg
5a2798dddb Support copy in parallel (#2258) 2017-09-29 14:36:16 -07:00
Aditya Manthramurthy
ca96cfc6e6 Move pkg/probe from vendor dir to package dir (#2236) 
The probe package is no longer available in the Minio server
repo. This change just moves probe from the vendor directory to its
own dir under `pkg`.

This is a maintenance fix.
 2017-08-14 11:13:38 -07:00
Anis Elleuch
313d0a358f cp: Set exit status to 1 for any error (#2127) 
Non fatal errors during copy were not setting mc exit code with 1. This
commit fixes the behavior.
 2017-04-15 00:20:13 -07:00
Harshavardhana
4425378b37 mc: Code cleanup after running gosimple tool (#2065) 2017-03-08 10:48:45 +01:00
Harshavardhana
1ef242a5c1 Fix all cli commands to have consistent UI (#2040) 
Fixes #2038
 2017-02-27 11:44:26 -08:00
Anis Elleuch
798775775b Use ` instead of unicode single quote (#2033) 
‘ is not supported in some dumb terminals, use ` instead
 2017-02-25 11:08:32 -08:00
Harshavardhana
e7e44b96ee Avoid printing hidden flags and commands with custom help. (#2015) 
Always use .VisibleFlags and .VisibleCommands in templates
to avoid printing hidden flags and commands in the help
template.
 2017-02-15 02:05:29 -08:00
Anis Elleuch
fb9d10772a help: Use {{.HelpName}} in help/examples template (#2013) 
It is easier to use {{.HelpName}} in help text template to print
the mc binary name plus the whole command hierarchy (binary name +
command + subcommand, etc..)
 2017-02-12 09:30:00 -08:00
Anis Elleuch
085a1e512f flags: use IsSet to fetch for cli flags (#1969) 
cli package fails to search for global flags when we use many level of subcommands. This PR uses context.IsSet() instead.
 2017-01-19 11:25:35 -08:00
Harshavardhana
64166319ee cp/diff/mirror: Cleanup code and deprecate unnecessary flags. (#1914) 
This fix also fixes an apparent crash found in diff.

```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4bdc07]

goroutine 84 [running]:
panic(0x810ea0, 0xc4200120e0)
        /home/builder/.gimme/versions/go1.7.3.linux.amd64/src/runtime/panic.go:500 +0x1a1
github.com/minio/mc/cmd.objectDifference.func1(0xc4200880a8, 0xc42042ee56, 0xc420315ec0, 0xc4200880b0, 0xc42042ee57, 0xc420315f20, 0xc42042ee54, 0xc42042ee55, 0xc420315501, 0xc4200880a0, ...)
        /home/builder/mygo/src/github.com/minio/mc/cmd/difference.go:109 +0x197
created by github.com/minio/mc/cmd.objectDifference
        /home/builder/mygo/src/github.com/minio/mc/cmd/difference.go:180 +0x2f5
```
 2016-12-06 01:41:22 -08:00
Harshavardhana
df395786bd mc: Consistent exit codes across all commands. (#1895) 
Also brings in much needed CLI changes from
upstream and backporting our custom changes on
top of those changes.

Fixes #1880
 2016-11-27 12:35:59 +05:30
Harshavardhana
2412aae68f cp/mirror: Use proper paths for windows during copyObject. (#1897) 
Fixes #1857
 2016-11-27 12:26:02 +05:30
Harshavardhana
38aec4d875 mirror and cp should print size in --json mode. (#1890) 
```sh
mc cp -r --json /usr/bin /tmp | jq .
...
...
{
  "status": "success",
  "source": "/usr/bin/gcm-viewer",
  "target": "/tmp/bin/gcm-viewer",
  "size": 87128,
  "totalCount": 2602,
  "totalSize": 677422730
}
```

This allows scripts to build progress around this data.
 2016-11-20 14:46:24 -08:00
Bala FA
0661f537cf update help messages of all commands. (#1856) 2016-10-17 20:18:55 -07:00
Harshavardhana
c6a383590d mc: Do not print accounting with '--json' (#1815) 2016-09-01 20:13:49 -07:00
Anis Elleuch
fd34958ffa Add --insecure flag to skip certificate validation (#1814) 2016-09-01 18:36:00 -07:00
Harshavardhana
2ea2ec90d2 Rename mc --> cmd 2016-08-17 18:26:18 -07:00