- Always set globals from context before validating input arguments.
- Add missing os.Exit(1) from console.Fatal{f,ln} which was
accidentally removed from previous commits.
Fixes#1472
Each command implements and interprets the following coloring styles
- ``dark`` - default coloring style picks up palette colors Cyan, Red, Blue, White etc
- ``light`` - lighter chooses white colored console printing.
- ``nocolor`` - nocolor is for console printing without any colors.
All coloring internally use ASCII color schemes, portable across all known OS.
Indentation while it is nice, leads to issues when parsing where delimiters on
readline() will fail since we are sending many self contained json's in a streaming
fashion, having a proper readline() based delimiter is helpful in terms of parsing.
- globalQuietFlag and globalJSONFlag should be checked in conjunction
for terminal features to be disabled. Otherwise ioctl fails for
calculating the term size.
- Avoid unnecessary scoping for probe, it has two different error sets now
- over the course of a project history every maintainer needs to update
its dependency packages, the problem essentially with godep is manipulating
GOPATH - this manipulation leads to static objects created at different locations
which end up conflicting with the overall functionality of golang.
This also leads to broken builds on many platforms. There is no easier way out of
this other than asking users to do 'godep restore' all the time which perhaps as
a practice doesn't sound clean, also has its own set of problems.
- govendor on the other hand is a right tool but a stop gap tool until we wait for
golangs official 1.5 version which fixes this vendoring issue once and for all.
- govendor makes sure that the import paths are re-written instead of manipulating
GOPATH.
This has advantages
- no more compiled objects being referenced in GOPATH and build time GOPATH
manging which leads to conflicts.
- proper import paths referencing the exact package a project is dependent on.
govendor is simple and provides the minimal necessary tooling to achieve this.
For now this is the right solution.
