minio/mc
minio/mc
1
0
Fork 0
mirror of https://github.com/minio/mc.git synced 2025-04-18 10:04:03 +03:00
Code

Add go runtime profile type (#5098)

Browse Source 
Available on AIStor.

Requires https://github.com/minio/madmin-go/pull/322

Lower minimum duration to 1 second. Useful (pretty much required) for traces.
This commit is contained in:
Klaus Post 2025-01-02 04:55:34 -08:00 committed by GitHub
parent bf7b5f620e
commit 147852cb37
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/admin-service-restart.go
View File

@ -269,6 +269,7 @@ func mainAdminServiceRestart(ctx *cli.Context) error {
})
if e != nil {
// Attempt an older API server might be old
//nolint:staticcheck
e = client.ServiceRestart(ctxt)
}
fatalIf(probe.NewError(e), "Unable to restart the server.")

4
cmd/admin-service-unfreeze.go
View File

@ -74,7 +74,7 @@ func checkAdminServiceUnfreezeSyntax(ctx *cli.Context) {
}
func mainAdminServiceUnfreeze(ctx *cli.Context) error {
// Validate serivce unfreeze syntax.
// Validate service unfreeze syntax.
checkAdminServiceUnfreezeSyntax(ctx)
// Set color.
@ -89,7 +89,7 @@ func mainAdminServiceUnfreeze(ctx *cli.Context) error {
fatalIf(err, "Unable to initialize admin connection.")
// Unfreeze the specified MinIO server
fatalIf(probe.NewError(client.ServiceUnfreeze(globalContext)), "Unable to unfreeze the server.")
fatalIf(probe.NewError(client.ServiceUnfreezeV2(globalContext)), "Unable to unfreeze the server.")
// Success..
printMsg(serviceUnfreezeCommand{Status: "success", ServerURL: aliasedURL})

2
cmd/client-fs_windows.go
View File

@ -56,6 +56,6 @@ func IsDeleteEvent(event notify.Event) bool {
// getAllXattrs returns the extended attributes for a file if supported
// by the OS
func getAllXattrs(path string) (map[string]string, error) {
func getAllXattrs(_ string) (map[string]string, error) {
return nil, nil
}

8
cmd/support-profile.go
View File

@ -119,7 +119,9 @@ func checkAdminProfileSyntax(ctx *cli.Context) {
string(madmin.ProfilerTrace),
string(madmin.ProfilerThreads),
string(madmin.ProfilerGoroutines),
string(madmin.ProfilerCPUIO))
string(madmin.ProfilerCPUIO),
string(madmin.ProfilerRuntime),
)
// Check if the provided profiler type is known and supported
profilers := strings.Split(strings.ToLower(ctx.String("type")), ",")
for _, profiler := range profilers {
@ -134,8 +136,8 @@ func checkAdminProfileSyntax(ctx *cli.Context) {
showCommandHelpAndExit(ctx, 1) // last argument is exit code
}
if ctx.Int("duration") < 10 {
fatal(errDummy().Trace(), "for any useful profiling one must run it for atleast 10 seconds")
if ctx.Int("duration") < 1 {
fatal(errDummy().Trace(), "for any useful profiling one must run it for at least 1 second")
}
}

2
go.mod
View File

@ -21,7 +21,7 @@ require (
github.com/minio/cli v1.24.2
github.com/minio/colorjson v1.0.8
github.com/minio/filepath v1.0.0
github.com/minio/madmin-go/v3 v3.0.78
github.com/minio/madmin-go/v3 v3.0.82-0.20241219154017-7a6a137d7ed6
github.com/minio/minio-go/v7 v7.0.82
github.com/minio/pkg/v3 v3.0.23
github.com/minio/selfupdate v0.6.0

4
go.sum
View File

@ -141,8 +141,8 @@ github.com/minio/colorjson v1.0.8 h1:AS6gEQ1dTRYHmC4xuoodPDRILHP/9Wz5wYUGDQfPLpg
github.com/minio/colorjson v1.0.8/go.mod h1:wrs39G/4kqNlGjwqHvPlAnXuc2tlPszo6JKdSBCLN8w=
github.com/minio/filepath v1.0.0 h1:fvkJu1+6X+ECRA6G3+JJETj4QeAYO9sV43I79H8ubDY=
github.com/minio/filepath v1.0.0/go.mod h1:/nRZA2ldl5z6jT9/KQuvZcQlxZIMQoFFQPvEXx9T/Bw=
github.com/minio/madmin-go/v3 v3.0.78 h1:JHUZU8akWSu8UF+mIBpsOSLtOG9b4ZTZVz3TShLbYn4=
github.com/minio/madmin-go/v3 v3.0.78/go.mod h1:IZOL4lEMiJ4QN2iWQjkOIIthcVuNYU7ENF7RkyxlzKY=
github.com/minio/madmin-go/v3 v3.0.82-0.20241219154017-7a6a137d7ed6 h1:ftB3HcXyqxWWN+WoqSSy5K+4muzvq+aMtdtu9zMLyCg=
github.com/minio/madmin-go/v3 v3.0.82-0.20241219154017-7a6a137d7ed6/go.mod h1:QAZPX3xx4gdZbZ8t85SieFSwXMOQhFx7bVjldhyc6Bk=
github.com/minio/md5-simd v1.1.2 h1:Gdi1DZK69+ZVMoNHRXJyNcxrMA4dSxoYHZSQbirFg34=
github.com/minio/md5-simd v1.1.2/go.mod h1:MzdKDxYpY2BT9XQFocsiZf/NKVtR7nkE4RoEpN+20RM=
github.com/minio/minio-go/v7 v7.0.82 h1:tWfICLhmp2aFPXL8Tli0XDTHj2VB/fNf0PC1f/i1gRo=

2
pkg/disk/stat_windows.go
View File

@ -22,6 +22,6 @@ package disk
// GetFileSystemAttrs return the file system attribute as string; containing mode,
// uid, gid, uname, Gname, atime, mtime, ctime and md5
func GetFileSystemAttrs(file string) (string, error) {
func GetFileSystemAttrs(_ string) (string, error) {
return "", nil
}