matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-07-30 02:21:17 +03:00
Code Activity

Fix escaped markdown passing backslashes through

Browse Source 
Fixes https://github.com/vector-im/riot-web/issues/11230

Signed-off-by: Bob Rao <bob+git@vulpin.com>
This commit is contained in:
BobVul
2020-01-31 12:33:10 +11:00
parent 6f6d6b096a
commit fde30577e4
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/editor/serialize.js
View File

@ -41,6 +41,10 @@ export function htmlSerializeIfNeeded(model, {forceHTML = false} = {}) {
if (!parser.isPlainText() || forceHTML) { if (!parser.isPlainText() || forceHTML) {
return parser.toHTML(); return parser.toHTML();
} }
// Format "plain" text to ensure removal of backslash escapes
// https://github.com/vector-im/riot-web/issues/11230
// https://github.com/vector-im/riot-web/issues/2870
return parser.toPlaintext();
} }
export function textSerialize(model) { export function textSerialize(model) {

6
test/editor/serialize-test.js
View File

@ -43,4 +43,10 @@ describe('editor/serialize', function() {
const html = htmlSerializeIfNeeded(model, {}); const html = htmlSerializeIfNeeded(model, {});
expect(html).toBe("<em>hello</em> world"); expect(html).toBe("<em>hello</em> world");
}); });
it('escaped markdown should not retain backslashes', function() {
const pc = createPartCreator();
const model = new EditorModel([pc.plain('\\*hello\\* world')]);
const html = htmlSerializeIfNeeded(model, {});
expect(html).toBe('*hello* world');
})
}); });