matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-16 06:42:26 +03:00
Code Activity

Don't prefix QR codes with the length of the static marker string

Browse Source 
Fixes https://github.com/vector-im/riot-web/issues/12489
This commit is contained in:
Travis Ralston
2020-02-25 09:54:48 -07:00
parent 6dcbed0320
commit f6fdddb9ba
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/components/views/elements/crypto/VerificationQRCode.js
View File

@@ -130,9 +130,9 @@ export default class VerificationQRCode extends React.PureComponent {
tmpBuf.writeInt8(i, 0); tmpBuf.writeInt8(i, 0);
buf = Buffer.concat([buf, tmpBuf]); buf = Buffer.concat([buf, tmpBuf]);
}; };
const appendStr = (s: string, enc: string) => { const appendStr = (s: string, enc: string, withLengthPrefix = true) => {
const tmpBuf = Buffer.from(s, enc); const tmpBuf = Buffer.from(s, enc);
appendInt(tmpBuf.byteLength); if (withLengthPrefix) appendInt(tmpBuf.byteLength);
buf = Buffer.concat([buf, tmpBuf]); buf = Buffer.concat([buf, tmpBuf]);
}; };
const appendEncBase64 = (b64: string) => { const appendEncBase64 = (b64: string) => {
@@ -142,7 +142,7 @@ export default class VerificationQRCode extends React.PureComponent {
}; };
// Actually build the buffer for the QR code // Actually build the buffer for the QR code
appendStr(this.props.prefix, "ascii"); appendStr(this.props.prefix, "ascii", false);
appendByte(this.props.version); appendByte(this.props.version);
appendByte(this.props.mode); appendByte(this.props.mode);
appendStr(this.props.transactionId, "utf-8"); appendStr(this.props.transactionId, "utf-8");