matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-07-30 02:21:17 +03:00
Code Activity

Use h1 as first heading in dialogs (#12250)

Browse Source 
* Use h1 as first heading in dialogs

The dialog should be modal and therefore the only content active
on the screen, so the title of the dialog should be the top level.

Update snapshots & tests appropriately.

* Just customise the letter spacing on dialog titles
This commit is contained in:
David Baker
2024-02-16 14:23:33 +00:00
committed by GitHub
parent b5048bf63e
commit e8ce9cb360
21 changed files with 71 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
playwright/e2e/user-onboarding/user-onboarding-new.spec.ts
View File

@ -43,7 +43,7 @@ test.describe("User Onboarding (new user)", () => {
test("app download dialog", async ({ page }) => {
await page.getByRole("button", { name: "Download apps" }).click();
await expect(
page.getByRole("dialog").getByRole("heading", { level: 2, name: "Download Element" }),
page.getByRole("dialog").getByRole("heading", { level: 1, name: "Download Element" }),
).toBeVisible();
await expect(page.locator(".mx_Dialog")).toMatchScreenshot();
});