matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-19 05:22:13 +03:00
Code Activity

only capture Enter when autocompletion list has selection

Browse Source 
this is the old behaviour and makes sense IMO
also close the auto complete when resetting the composer model,
in case it was still open
This commit is contained in:
Bruno Windels
2019-08-21 16:22:04 +02:00
parent 3c5cf3e778
commit e2dfe888cc
3 changed files with 31 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/components/views/rooms/BasicMessageComposer.js
View File

@@ -203,19 +203,32 @@ export default class BasicMessageEditor extends React.Component {
const autoComplete = model.autoComplete;
switch (event.key) {
case "Enter":
autoComplete.onEnter(event); break;
// only capture enter when something is selected in the list,
// otherwise don't handle so the contents of the composer gets sent
if (autoComplete.hasSelection()) {
autoComplete.onEnter(event);
handled = true;
}
break;
case "ArrowUp":
autoComplete.onUpArrow(event); break;
autoComplete.onUpArrow(event);
handled = true;
break;
case "ArrowDown":
autoComplete.onDownArrow(event); break;
autoComplete.onDownArrow(event);
handled = true;
break;
case "Tab":
autoComplete.onTab(event); break;
autoComplete.onTab(event);
handled = true;
break;
case "Escape":
autoComplete.onEscape(event); break;
autoComplete.onEscape(event);
handled = true;
break;
default:
return; // don't preventDefault on anything else
}
handled = true;
}
}
if (handled) {