matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-16 06:42:26 +03:00
Code Activity

Fix a number of minor code quality issues

Browse Source 
Most of these are complaints from my IDE. Discovered by going through nearly every file looking for React warnings.
This commit is contained in:
Travis Ralston
2020-03-31 14:05:56 -06:00
parent 56dda3895c
commit c86d75693b
11 changed files with 12 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/components/structures/GroupView.js
View File

@@ -433,7 +433,6 @@ export default createReactClass({
this._matrixClient = MatrixClientPeg.get();
this._matrixClient.on("Group.myMembership", this._onGroupMyMembership);
this._changeAvatarComponent = null;
this._initGroupStore(this.props.groupId, true);
this._dispatcherRef = dis.register(this._onAction);

2
src/components/structures/auth/SoftLogout.js
View File

@@ -54,7 +54,7 @@ export default class SoftLogout extends React.Component {
this.state = {
loginView: LOGIN_VIEW.LOADING,
keyBackupNeeded: true, // assume we do while we figure it out (see componentWillMount)
keyBackupNeeded: true, // assume we do while we figure it out (see componentDidMount)
busy: false,
password: "",

2
src/components/views/dialogs/RoomSettingsDialog.js
View File

@@ -41,7 +41,7 @@ export default class RoomSettingsDialog extends React.Component {
}
componentWillUnmount() {
dis.unregister(this._dispatcherRef);
if (this._dispatcherRef) dis.unregister(this._dispatcherRef);
}
_onAction = (payload) => {

2
src/components/views/elements/AppTile.js
View File

@@ -161,7 +161,7 @@ export default class AppTile extends React.Component {
componentWillUnmount() {
// Widget action listeners
dis.unregister(this.dispatcherRef);
if (this.dispatcherRef) dis.unregister(this.dispatcherRef);
// if it's not remaining on screen, get rid of the PersistedElement container
if (!ActiveWidgetStore.getWidgetPersistence(this.props.id)) {

4
src/components/views/elements/LanguageDropdown.js
View File

@@ -24,8 +24,8 @@ import SettingsStore from "../../../settings/SettingsStore";
import { _t } from "../../../languageHandler";
function languageMatchesSearchQuery(query, language) {
if (language.label.toUpperCase().indexOf(query.toUpperCase()) == 0) return true;
if (language.value.toUpperCase() == query.toUpperCase()) return true;
if (language.label.toUpperCase().includes(query.toUpperCase())) return true;
if (language.value.toUpperCase() === query.toUpperCase()) return true;
return false;
}

2
src/components/views/elements/Pill.js
View File

@@ -158,7 +158,7 @@ const Pill = createReactClass({
componentWillMount() {
this._unmounted = false;
this._matrixClient = MatrixClientPeg.get();
this.componentWillReceiveProps(this.props);
this.componentWillReceiveProps(this.props); // HACK: We shouldn't be calling lifecycle functions ourselves.
},
componentWillUnmount() {

2
src/components/views/rooms/AppsDrawer.js
View File

@@ -71,7 +71,7 @@ export default createReactClass({
MatrixClientPeg.get().removeListener('RoomState.events', this.onRoomStateEvents);
}
WidgetEchoStore.removeListener('update', this._updateApps);
dis.unregister(this.dispatcherRef);
if (this.dispatcherRef) dis.unregister(this.dispatcherRef);
},
componentWillReceiveProps(newProps) {

1
src/components/views/rooms/RoomRecoveryReminder.js
View File

@@ -61,7 +61,6 @@ export default class RoomRecoveryReminder extends React.PureComponent {
loading: false,
error: e,
});
return;
}
}