matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-14 19:02:33 +03:00
Code Activity

turn NPE into a throw

Browse Source
This commit is contained in:
Matthew Hodgson
2019-04-04 16:53:17 +01:00
parent e98ef0d537
commit b9eebee13b
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/matrix-to.js
View File

@@ -239,9 +239,13 @@ export function makeUserPermalink(userId) {
export function makeRoomPermalink(roomId) { export function makeRoomPermalink(roomId) {
const permalinkBase = `${baseUrl}/#/${roomId}`; const permalinkBase = `${baseUrl}/#/${roomId}`;
if (!roomId) {
throw new Error("can't permalink a falsey roomId");
}
// If the roomId isn't actually a room ID, don't try to list the servers. // If the roomId isn't actually a room ID, don't try to list the servers.
// Aliases are already routable, and don't need extra information. // Aliases are already routable, and don't need extra information.
if (!roomId || roomId[0] !== '!') return permalinkBase; if (roomId[0] !== '!') return permalinkBase;
const client = MatrixClientPeg.get(); const client = MatrixClientPeg.get();
const room = client.getRoom(roomId); const room = client.getRoom(roomId);