matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-20 16:22:28 +03:00
Code Activity

Fix Analytics to not import DEFAULTS, therefore avoiding NPE

Browse Source
This commit is contained in:
Luke Barnard
2018-04-26 14:30:27 +01:00
parent fba1a0c4c7
commit b1af4ec9fd
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/Analytics.js
View File

@@ -16,7 +16,7 @@
import { getCurrentLanguage, _t, _td } from './languageHandler'; import { getCurrentLanguage, _t, _td } from './languageHandler';
import PlatformPeg from './PlatformPeg'; import PlatformPeg from './PlatformPeg';
import SdkConfig, { DEFAULTS } from './SdkConfig'; import SdkConfig from './SdkConfig';
import Modal from './Modal'; import Modal from './Modal';
import sdk from './index'; import sdk from './index';
@@ -199,8 +199,8 @@ class Analytics {
const config = SdkConfig.get(); const config = SdkConfig.get();
if (!config.piwik) return; if (!config.piwik) return;
const whitelistedHSUrls = config.piwik.whitelistedHSUrls || DEFAULTS.piwik.whitelistedHSUrls; const whitelistedHSUrls = config.piwik.whitelistedHSUrls;
const whitelistedISUrls = config.piwik.whitelistedISUrls || DEFAULTS.piwik.whitelistedISUrls; const whitelistedISUrls = config.piwik.whitelistedISUrls;
this._setVisitVariable('User Type', isGuest ? 'Guest' : 'Logged In'); this._setVisitVariable('User Type', isGuest ? 'Guest' : 'Logged In');
this._setVisitVariable('Homeserver URL', whitelistRedact(whitelistedHSUrls, homeserverUrl)); this._setVisitVariable('Homeserver URL', whitelistRedact(whitelistedHSUrls, homeserverUrl));

1
src/SdkConfig.js
View File

@@ -45,4 +45,3 @@ class SdkConfig {
} }
module.exports = SdkConfig; module.exports = SdkConfig;
module.exports.DEFAULTS = DEFAULTS;