matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-07 10:46:24 +03:00
Code Activity

Move HeaderButtons to an abstract class

Browse Source
This commit is contained in:
Michael Telatynski
2020-09-03 15:01:32 +01:00
parent c7e40d0751
commit ad9be61477
3 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/views/right_panel/GroupHeaderButtons.tsx
View File

@@ -46,8 +46,6 @@ export default class GroupHeaderButtons extends HeaderButtons {
} }
protected onAction(payload: ActionPayload) { protected onAction(payload: ActionPayload) {
super.onAction(payload);
if (payload.action === Action.ViewUser) { if (payload.action === Action.ViewUser) {
if ((payload as ViewUserPayload).member) { if ((payload as ViewUserPayload).member) {
this.setPhase(RightPanelPhases.RoomMemberInfo, {member: payload.member}); this.setPhase(RightPanelPhases.RoomMemberInfo, {member: payload.member});

4
src/components/views/right_panel/HeaderButtons.tsx
View File

@@ -65,9 +65,7 @@ export default abstract class HeaderButtons extends React.Component<IProps, ISta
if (this.dispatcherRef) dis.unregister(this.dispatcherRef); if (this.dispatcherRef) dis.unregister(this.dispatcherRef);
} }
protected onAction(payload) { protected abstract onAction(payload);
// Ignore - intended to be overridden by subclasses
}
public setPhase(phase: RightPanelPhases, extras?: Partial<SetRightPanelPhaseRefireParams>) { public setPhase(phase: RightPanelPhases, extras?: Partial<SetRightPanelPhaseRefireParams>) {
dis.dispatch<SetRightPanelPhasePayload>({ dis.dispatch<SetRightPanelPhasePayload>({

4
src/components/views/right_panel/RoomHeaderButtons.tsx
View File

@@ -36,13 +36,9 @@ const MEMBER_PHASES = [
export default class RoomHeaderButtons extends HeaderButtons { export default class RoomHeaderButtons extends HeaderButtons {
constructor(props) { constructor(props) {
super(props, HeaderKind.Room); super(props, HeaderKind.Room);
this.onMembersClicked = this.onMembersClicked.bind(this);
this.onFilesClicked = this.onFilesClicked.bind(this);
this.onNotificationsClicked = this.onNotificationsClicked.bind(this);
} }
protected onAction(payload: ActionPayload) { protected onAction(payload: ActionPayload) {
super.onAction(payload);
if (payload.action === Action.ViewUser) { if (payload.action === Action.ViewUser) {
if (payload.member) { if (payload.member) {
this.setPhase(RightPanelPhases.RoomMemberInfo, {member: payload.member}); this.setPhase(RightPanelPhases.RoomMemberInfo, {member: payload.member});