matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-07-28 15:22:05 +03:00
Code Activity

Flag componentWillUpdate as UNSAFE in MatrixChat

Browse Source 
For https://github.com/vector-im/riot-web/issues/12877
This commit is contained in:
Travis Ralston
2020-04-01 14:32:35 -06:00
parent 0bb8973ee6
commit ab6bd4104f
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/structures/MatrixChat.js
View File

@ -360,7 +360,8 @@ export default createReactClass({
if (this._accountPasswordTimer !== null) clearTimeout(this._accountPasswordTimer); if (this._accountPasswordTimer !== null) clearTimeout(this._accountPasswordTimer);
}, },
componentWillUpdate: function(props, state) { // TODO: [REACT-WARNING] Replace with appropriate lifecycle stage
UNSAFE_componentWillUpdate: function(props, state) {
if (this.shouldTrackPageChange(this.state, state)) { if (this.shouldTrackPageChange(this.state, state)) {
this.startPageChangeTimer(); this.startPageChangeTimer();
} }
@ -381,7 +382,7 @@ export default createReactClass({
// Tor doesn't support performance // Tor doesn't support performance
if (!performance || !performance.mark) return null; if (!performance || !performance.mark) return null;
// This shouldn't happen because componentWillUpdate and componentDidUpdate // This shouldn't happen because UNSAFE_componentWillUpdate and componentDidUpdate
// are used. // are used.
if (this._pageChanging) { if (this._pageChanging) {
console.warn('MatrixChat.startPageChangeTimer: timer already started'); console.warn('MatrixChat.startPageChangeTimer: timer already started');