matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-14 19:02:33 +03:00
Code Activity

Fix a couple of bugs with EditableItemList

Browse Source 
- fix entering the same thing twice (which had the bug of not emptying the "new" field)
 - fix editing items in the list (which would stack overflow because of typo)
This commit is contained in:
Luke Barnard
2017-10-04 13:15:38 +01:00
parent 1938a767a2
commit 9e3954865a
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/views/elements/EditableItemList.js
View File

@@ -104,7 +104,7 @@ module.exports = React.createClass({
if (value.length === 0) {
this.onItemRemoved(index);
} else {
this.onItemEdited(value, index);
this.props.onItemEdited(value, index);
}
},

4
src/components/views/elements/EditableText.js
View File

@@ -65,7 +65,9 @@ module.exports = React.createClass({
},
componentWillReceiveProps: function(nextProps) {
if (nextProps.initialValue !== this.props.initialValue) {
if (nextProps.initialValue !== this.props.initialValue ||
nextProps.initialValue !== this.value
) {
this.value = nextProps.initialValue;
if (this.refs.editable_div) {
this.showPlaceholder(!this.value);