matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-08 21:42:24 +03:00
Code Activity

Update reasoning around disabling capture_pageview

Browse Source
This commit is contained in:
James Salter
2021-07-21 16:29:11 +01:00
parent 34f8c60b34
commit 93962c0aca
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/PosthogAnalytics.ts
View File

@@ -93,9 +93,11 @@ export class PosthogAnalytics {
autocapture: false,
mask_all_text: true,
mask_all_element_attributes: true,
// this is disabled for now as its tricky to sanitize properties of the pageview
// event because sanitization requires async crypto calls and the sanitize_properties
// callback is synchronous.
// This only triggers on page load, which for our SPA isn't particularly useful.
// Plus, the .capture call originating from somewhere in posthog makes it hard
// to redact URLs, which requires async code.
//
// To raise this manually, just call .capture("$pageview") or posthog.capture_pageview.
capture_pageview: false,
sanitize_properties: this.sanitizeProperties.bind(this),
respect_dnt: true,