matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-07-28 15:22:05 +03:00
Code Activity

Merge pull request #2247 from matrix-org/dbkr/fix_emoji_replacement

Browse Source 
Fix emoji replacement in composer
This commit is contained in:
David Baker
2018-10-25 16:23:13 +01:00
committed by GitHub
parent 8d47baa95a 5e81e5b8b8
commit 85bb8392c4
1 changed files with 34 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/components/views/rooms/MessageComposerInput.js
View File

@ -573,9 +573,14 @@ export default class MessageComposerInput extends React.Component {
} }
// emojioneify any emoji // emojioneify any emoji
editorState.document.getTexts().forEach(node => { let foundEmoji;
do {
foundEmoji = false;
for (const node of editorState.document.getTexts()) {
if (node.text !== '' && HtmlUtils.containsEmoji(node.text)) { if (node.text !== '' && HtmlUtils.containsEmoji(node.text)) {
let match; let match;
EMOJI_REGEX.lastIndex = 0;
while ((match = EMOJI_REGEX.exec(node.text)) !== null) { while ((match = EMOJI_REGEX.exec(node.text)) !== null) {
const range = Range.create({ const range = Range.create({
anchor: { anchor: {
@ -593,9 +598,17 @@ export default class MessageComposerInput extends React.Component {
}); });
change = change.insertInlineAtRange(range, inline); change = change.insertInlineAtRange(range, inline);
editorState = change.value; editorState = change.value;
// if we replaced an emoji, start again looking for more
// emoji in the new editor state since doing the replacement
// will change the node structure & offsets so we can't compute
// insertion ranges from node.key / match.index anymore.
foundEmoji = true;
break;
} }
} }
}); }
} while (foundEmoji);
// work around weird bug where inserting emoji via the macOS // work around weird bug where inserting emoji via the macOS
// emoji picker can leave the selection stuck in the emoji's // emoji picker can leave the selection stuck in the emoji's