matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-07 10:46:24 +03:00
Code Activity

Add comments regarding tab-index=-1

Browse Source
This commit is contained in:
Michael Telatynski
2019-11-04 10:16:16 +00:00
parent fd4cdd0dec
commit 6d3b563119
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/components/views/messages/DateSeparator.js
View File

@@ -57,6 +57,7 @@ export default class DateSeparator extends React.Component {
render() { render() {
// ARIA treats <hr/>s as separators, here we abuse them slightly so manually treat this entire thing as one // ARIA treats <hr/>s as separators, here we abuse them slightly so manually treat this entire thing as one
// tab-index=-1 to allow it to be focusable but do not add tab stop for it, primarily for screen readers
return <h2 className="mx_DateSeparator" role="separator" tabIndex={-1}> return <h2 className="mx_DateSeparator" role="separator" tabIndex={-1}>
<hr role="none" /> <hr role="none" />
<div>{ this.getLabel() }</div> <div>{ this.getLabel() }</div>

1
src/components/views/rooms/EventTile.js
View File

@@ -787,6 +787,7 @@ module.exports = createReactClass({
this.props.permalinkCreator, this.props.permalinkCreator,
'replyThread', 'replyThread',
); );
// tab-index=-1 to allow it to be focusable but do not add tab stop for it, primarily for screen readers
return ( return (
<div className={classes} tabIndex={-1}> <div className={classes} tabIndex={-1}>
<div className="mx_EventTile_msgOption"> <div className="mx_EventTile_msgOption">