matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-08 21:42:24 +03:00
Code Activity

Remove bits of Field that supported uncontrolled

Browse Source 
Field is no longer used as an uncontrolled component, so we can remove some
supporting code that we no longer need.
This commit is contained in:
J. Ryan Stinnett
2019-03-12 16:51:19 +00:00
parent d4dbba3938
commit 69a066657b
1 changed files with 1 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
src/components/views/elements/Field.js
View File

@@ -53,22 +53,9 @@ export default class Field extends React.PureComponent {
}; };
} }
/* TODO: Remove me */
get value() {
if (!this.refs.fieldInput) return null;
return this.refs.fieldInput.value;
}
set value(newValue) {
if (!this.refs.fieldInput) {
throw new Error("No field input reference");
}
this.refs.fieldInput.value = newValue;
}
onChange = (ev) => { onChange = (ev) => {
if (this.props.onValidate) { if (this.props.onValidate) {
const result = this.props.onValidate(this.value); const result = this.props.onValidate(ev.target.value);
this.setState({ this.setState({
valid: result.valid, valid: result.valid,
feedback: result.feedback, feedback: result.feedback,
@@ -92,12 +79,6 @@ export default class Field extends React.PureComponent {
inputProps.onChange = this.onChange; inputProps.onChange = this.onChange;
/* TODO: Remove me */
// make sure we use the current `value` for the field and not the original one
if (inputProps.value === undefined) {
inputProps.value = this.value || "";
}
const fieldInput = React.createElement(inputElement, inputProps, children); const fieldInput = React.createElement(inputElement, inputProps, children);
let prefixContainer = null; let prefixContainer = null;