Comply with noImplicitAny (#9940)

* Stash noImplicitAny work

* Stash

* Fix imports

* Iterate

* Fix tests

* Delint

* Fix tests

test/components/views/messages/DateSeparator-test.tsx

@@ -40,7 +40,7 @@ describe("DateSeparator", () => {
     };
     const RealDate = global.Date;
     class MockDate extends Date {
-        constructor(date) {
+        constructor(date: string | number | Date) {
             super(date || now);
         }
     }

test/components/views/messages/MBeaconBody-test.tsx

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import React from "react";
+import React, { ComponentProps } from "react";
 // eslint-disable-next-line deprecate/import
 import { mount } from "enzyme";
 import { act } from "react-dom/test-utils";
@@ -63,7 +63,7 @@ describe("<MBeaconBody />", () => {
 
     const defaultEvent = makeBeaconInfoEvent(aliceId, roomId, { isLive: true }, "$alice-room1-1");
 
-    const defaultProps = {
+    const defaultProps: ComponentProps<typeof MBeaconBody> = {
         mxEvent: defaultEvent,
         highlights: [],
         highlightLink: "",
@@ -343,7 +343,7 @@ describe("<MBeaconBody />", () => {
 
         const redactionEvent = new MatrixEvent({ type: EventType.RoomRedaction, content: { reason: "test reason" } });
 
-        const setupRoomWithBeacon = (beaconInfoEvent, locationEvents: MatrixEvent[] = []) => {
+        const setupRoomWithBeacon = (beaconInfoEvent: MatrixEvent, locationEvents: MatrixEvent[] = []) => {
             const room = makeRoomWithStateEvents([beaconInfoEvent], { roomId, mockClient });
             const beaconInstance = room.currentState.beacons.get(getBeaconInfoIdentifier(beaconInfoEvent));
             beaconInstance.addLocations(locationEvents);

test/components/views/messages/MLocationBody-test.tsx

@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import React from "react";
+import React, { ComponentProps } from "react";
 // eslint-disable-next-line deprecate/import
 import { mount } from "enzyme";
 import { LocationAssetType } from "matrix-js-sdk/src/@types/location";
@@ -46,7 +46,7 @@ describe("MLocationBody", () => {
             isGuest: jest.fn().mockReturnValue(false),
         });
         const defaultEvent = makeLocationEvent("geo:51.5076,-0.1276", LocationAssetType.Pin);
-        const defaultProps = {
+        const defaultProps: ComponentProps<typeof MLocationBody> = {
             mxEvent: defaultEvent,
             highlights: [],
             highlightLink: "",
@@ -79,7 +79,7 @@ describe("MLocationBody", () => {
         });
 
         describe("with error", () => {
-            let sdkConfigSpy;
+            let sdkConfigSpy: jest.SpyInstance<any>;
 
             beforeEach(() => {
                 // eat expected errors to keep console clean
@@ -171,7 +171,7 @@ describe("MLocationBody", () => {
                 const component = getComponent({ mxEvent: selfShareEvent });
 
                 // render self locations with user avatars
-                expect(component.find("SmartMarker").at(0).props()["roomMember"]).toEqual(member);
+                expect(component.find("SmartMarker").at(0).prop("roomMember")).toEqual(member);
             });
         });
     });

test/components/views/messages/MVideoBody-test.tsx

@@ -14,8 +14,8 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import React from "react";
-import { MatrixEvent } from "matrix-js-sdk/src/matrix";
+import React, { ComponentProps } from "react";
+import { IContent, MatrixEvent } from "matrix-js-sdk/src/matrix";
 import { render, RenderResult } from "@testing-library/react";
 
 import MatrixClientContext from "../../../../src/contexts/MatrixClientContext";
@@ -43,7 +43,7 @@ describe("MVideoBody", () => {
 });
 
 function makeMVideoBody(w: number, h: number): RenderResult {
-    const content = {
+    const content: IContent = {
         info: {
             "w": w,
             "h": h,
@@ -66,7 +66,7 @@ function makeMVideoBody(w: number, h: number): RenderResult {
         content,
     });
 
-    const defaultProps = {
+    const defaultProps: ComponentProps<typeof MVideoBody> = {
         mxEvent: event,
         highlights: [],
         highlightLink: "",

test/components/views/messages/MessageActionBar-test.tsx

@@ -76,7 +76,7 @@ describe("<MessageActionBar />", () => {
     });
 
     const localStorageMock = (() => {
-        let store = {};
+        let store: Record<string, any> = {};
         return {
             getItem: jest.fn().mockImplementation((key) => store[key] ?? null),
             setItem: jest.fn().mockImplementation((key, value) => {

test/components/views/messages/TextualBody-test.tsx

@@ -15,7 +15,7 @@ limitations under the License.
 */
 
 import React from "react";
-import { MatrixClient } from "matrix-js-sdk/src/matrix";
+import { MatrixClient, MatrixEvent } from "matrix-js-sdk/src/matrix";
 import { MockedObject } from "jest-mock";
 import { render } from "@testing-library/react";
 
@@ -38,9 +38,9 @@ describe("<TextualBody />", () => {
     beforeEach(() => {
         defaultMatrixClient = getMockClientWithEventEmitter({
             getRoom: () => defaultRoom,
-            getAccountData: () => undefined,
+            getAccountData: (): MatrixEvent | undefined => undefined,
             isGuest: () => false,
-            mxcUrlToHttp: (s) => s,
+            mxcUrlToHttp: (s: string) => s,
         });
     });
 
@@ -56,7 +56,7 @@ describe("<TextualBody />", () => {
     });
     const defaultProps = {
         mxEvent: defaultEvent,
-        highlights: [],
+        highlights: [] as string[],
         highlightLink: "",
         onMessageAllowed: jest.fn(),
         onHeightChanged: jest.fn(),
@@ -158,17 +158,17 @@ describe("<TextualBody />", () => {
     });
 
     describe("renders formatted m.text correctly", () => {
-        let matrixClient;
+        let matrixClient: MatrixClient;
         beforeEach(() => {
             matrixClient = getMockClientWithEventEmitter({
                 getRoom: () => mkStubRoom("room_id", "room name", undefined),
-                getAccountData: () => undefined,
+                getAccountData: (): MatrixEvent | undefined => undefined,
                 getUserId: () => "@me:my_server",
                 getHomeserverUrl: () => "https://my_server/",
-                on: () => undefined,
-                removeListener: () => undefined,
+                on: (): void => undefined,
+                removeListener: (): void => undefined,
                 isGuest: () => false,
-                mxcUrlToHttp: (s) => s,
+                mxcUrlToHttp: (s: string) => s,
             });
             DMRoomMap.makeShared();
         });
@@ -375,10 +375,10 @@ describe("<TextualBody />", () => {
 
         const matrixClient = getMockClientWithEventEmitter({
             getRoom: () => mkStubRoom("room_id", "room name", undefined),
-            getAccountData: () => undefined,
-            getUrlPreview: (url) => new Promise(() => {}),
+            getAccountData: (): MatrixClient | undefined => undefined,
+            getUrlPreview: (url: string) => new Promise(() => {}),
             isGuest: () => false,
-            mxcUrlToHttp: (s) => s,
+            mxcUrlToHttp: (s: string) => s,
         });
         DMRoomMap.makeShared();