matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-08 21:42:24 +03:00
Code Activity

Add comments explaining our non standard usage of aria-described-by

Browse Source
This commit is contained in:
Peter Vágner
2018-02-12 21:13:53 +01:00
parent 410570936a
commit 5e9368e794
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/components/views/dialogs/BaseDialog.js
View File

@@ -76,6 +76,12 @@ export default React.createClass({
className={this.props.className} className={this.props.className}
role="dialog" role="dialog"
aria-labelledby='mx_BaseDialog_title' aria-labelledby='mx_BaseDialog_title'
// This should point to a node describing the dialog.
// If we were about to completelly follow this recommendation we'd need to
// make all the components relying on BaseDialog to be aware of it.
// So instead we will use the whole content as the description.
// Description comes first and if the content contains more text,
// AT users can skip its presentation.
aria-describedby={this.props.contentId} aria-describedby={this.props.contentId}
> >
<AccessibleButton onClick={this._onCancelClick} <AccessibleButton onClick={this._onCancelClick}