matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-11-11 20:22:36 +03:00
Code Activity

* Fix key error

Browse Source 
* Remove redundant logging
* Catch error
This commit is contained in:
Richard Lewis
2018-01-15 14:22:41 +00:00
parent 0fab905a2e
commit 5e6da4d758
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/views/elements/AppTile.js
View File

@@ -41,7 +41,6 @@ export default class AppTile extends React.Component {
constructor(props) { constructor(props) {
super(props); super(props);
console.warn('AppTile constructor', props);
this.state = this._getNewState(props); this.state = this._getNewState(props);
this._onAction = this._onAction.bind(this); this._onAction = this._onAction.bind(this);
@@ -218,8 +217,12 @@ export default class AppTile extends React.Component {
} }
componentWillUnmount() { componentWillUnmount() {
try {
this.widgetMessaging.stopListening(); this.widgetMessaging.stopListening();
this.widgetMessaging.removeEndpoint(this.props.id, this.props.url); this.widgetMessaging.removeEndpoint(this.props.id, this.props.url);
} catch (e) {
console.error('Failed to stop listening for widgetMessaging events', e.message);
}
dis.unregister(this._onAction); dis.unregister(this._onAction);
window.removeEventListener('message', this._onMessage); window.removeEventListener('message', this._onMessage);
} }

1
src/components/views/rooms/MessageComposer.js
View File

@@ -354,6 +354,7 @@ export default class MessageComposer extends React.Component {
isOpen={this.state.showStickers} isOpen={this.state.showStickers}
position={'top'} position={'top'}
padding={1} padding={1}
key='stickersPopover'
content={({ position, targetRect, popoverRect }) => ( content={({ position, targetRect, popoverRect }) => (
<ArrowContainer <ArrowContainer
position={position} position={position}