matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-07-30 02:21:17 +03:00
Code Activity

nest quotes, but only when people want to click through them

Browse Source 
loads pre-emptively

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
This commit is contained in:
Michael Telatynski
2017-12-18 19:28:01 +00:00
parent 882068078d
commit 47d4e5f8d1
2 changed files with 29 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/components/views/elements/Quote.js
View File

@ -54,6 +54,8 @@ export default class Quote extends React.Component {
url: PropTypes.string,
// The parent event
parentEv: PropTypes.instanceOf(MatrixEvent),
// Whether this isn't the first Quote, and we're being nested
isNested: PropTypes.bool,
};
constructor(props, context) {
@ -62,7 +64,10 @@ export default class Quote extends React.Component {
this.state = {
// The event related to this quote
event: null,
show: !this.props.isNested,
};
this.onShowNested = this.onShowNested.bind(this);
}
getChildContext() {
@ -112,9 +117,16 @@ export default class Quote extends React.Component {
this.setState({room, event});
}
onShowNested() {
this.setState({
show: true,
});
}
render() {
const ev = this.state.event;
if (ev) {
if (this.state.show) {
const EventTile = sdk.getComponent('views.rooms.EventTile');
let dateSep = null;
if (wantsDateSeparator(this.props.parentEv, this.state.event)) {
@ -128,6 +140,12 @@ export default class Quote extends React.Component {
</blockquote>;
}
return <div>
<a onClick={this.onShowNested} className="mx_Quote_show">{ _t('Quote') }</a>
<br />
</div>;
}
// Deliberately render nothing if the URL isn't recognised
return <div>
<a href={this.props.url}>{ _t('Quote') }</a>

6
src/components/views/messages/TextualBody.js
View File

@ -202,14 +202,12 @@ module.exports = React.createClass({
// update the current node with one that's now taken its place
node = pillContainer;
} else if (SettingsStore.isFeatureEnabled("feature_rich_quoting") && this.props.tileShape !== 'quote' &&
Quote.isMessageUrl(href)
) {
} else if (SettingsStore.isFeatureEnabled("feature_rich_quoting") && Quote.isMessageUrl(href)) {
// only allow this branch if we're not already in a quote, as fun as infinite nesting is.
const quoteContainer = document.createElement('span');
const quote =
<Quote url={href} parentEv={this.props.mxEvent} />;
<Quote url={href} parentEv={this.props.mxEvent} isNested={this.props.tileShape === 'quote'} />;
ReactDOM.render(quote, quoteContainer);
node.parentNode.replaceChild(quoteContainer, node);