matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2026-01-03 21:42:32 +03:00
Code Activity

Fix tooltip infinitely recursing (#9235)

Browse Source
This commit is contained in:
Michael Telatynski
2022-09-02 10:03:53 +01:00
committed by GitHub
parent d1237b2c98
commit 3e8da6ffa4
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/components/views/elements/Tooltip.tsx
View File

@@ -22,6 +22,7 @@ import ReactDOM from 'react-dom';
import classNames from 'classnames';
import UIStore from "../../../stores/UIStore";
import { objectHasDiff } from "../../../utils/objects";
export enum Alignment {
Natural, // Pick left or right
@@ -91,8 +92,10 @@ export default class Tooltip extends React.PureComponent<ITooltipProps, State> {
this.updatePosition();
}
public componentDidUpdate() {
this.updatePosition();
public componentDidUpdate(prevProps) {
if (objectHasDiff(prevProps, this.props)) {
this.updatePosition();
}
}
// Remove the wrapper element, as the tooltip has finished using it