matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-07-28 15:22:05 +03:00
Code Activity

Abort scroll updates when already unmounted

Browse Source 
This checks whether we're unmounted before updating scroll state, as we use
async functions and timeouts in this area.

Fixes https://github.com/vector-im/riot-web/issues/11150
This commit is contained in:
J. Ryan Stinnett
2019-10-18 18:01:57 +01:00
parent 5333201823
commit 3a428efb60
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/components/structures/ScrollPanel.js
View File

@ -677,6 +677,11 @@ module.exports = createReactClass({
debuglog("updateHeight getting straight to business, no scrolling going on."); debuglog("updateHeight getting straight to business, no scrolling going on.");
} }
// We might have unmounted since the timer finished, so abort if so.
if (this.unmounted) {
return;
}
const sn = this._getScrollNode(); const sn = this._getScrollNode();
const itemlist = this.refs.itemlist; const itemlist = this.refs.itemlist;
const contentHeight = this._getMessagesHeight(); const contentHeight = this._getMessagesHeight();