matrix/matrix-react-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-react-sdk.git synced 2025-07-28 15:22:05 +03:00
Code Activity

Address review comments and fix lint errors

Browse Source
This commit is contained in:
Peter Vágner
2018-10-02 20:32:54 +02:00
parent e05ae29146
commit 2b394c1869
3 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/components/structures/UserSettings.js
View File

@ -1233,10 +1233,10 @@ module.exports = React.createClass({
value={this.presentableTextForThreepid(val)} disabled value={this.presentableTextForThreepid(val)} disabled
/> />
</div> </div>
<AccessibleButton className="mx_UserSettings_threepidButton mx_filterFlipColor"> <div className="mx_UserSettings_threepidButton mx_filterFlipColor">
<img src="img/cancel-small.svg" width="14" height="14" alt={_t("Remove")} <AccessibleButton element="img" src="img/cancel-small.svg" width="14" height="14" alt={_t("Remove")}
onClick={onRemoveClick} /> onClick={onRemoveClick} />
</AccessibleButton> </div>
</div> </div>
); );
}); });
@ -1258,9 +1258,9 @@ module.exports = React.createClass({
blurToCancel={false} blurToCancel={false}
onValueChanged={this._onAddEmailEditFinished} /> onValueChanged={this._onAddEmailEditFinished} />
</div> </div>
<AccessibleButton className="mx_UserSettings_threepidButton mx_filterFlipColor"> <div className="mx_UserSettings_threepidButton mx_filterFlipColor">
<img src="img/plus.svg" width="14" height="14" alt={_t("Add")} onClick={this._addEmail} /> <AccessibleButton element="img" src="img/plus.svg" width="14" height="14" alt={_t("Add")} onClick={this._addEmail} />
</AccessibleButton> </div>
</div> </div>
); );
} }
@ -1339,14 +1339,14 @@ module.exports = React.createClass({
<ChangeAvatar ref="changeAvatar" initialAvatarUrl={avatarUrl} <ChangeAvatar ref="changeAvatar" initialAvatarUrl={avatarUrl}
showUploadSection={false} className="mx_UserSettings_avatarPicker_img" /> showUploadSection={false} className="mx_UserSettings_avatarPicker_img" />
</div> </div>
<AccessibleButton className="mx_UserSettings_avatarPicker_edit"> <div className="mx_UserSettings_avatarPicker_edit">
<label htmlFor="avatarInput" ref="file_label"> <label htmlFor="avatarInput" ref="file_label">
<img src="img/camera.svg" className="mx_filterFlipColor" <img src="img/camera.svg" className="mx_filterFlipColor"
alt={_t("Upload avatar")} title={_t("Upload avatar")} alt={_t("Upload avatar")} title={_t("Upload avatar")}
width="17" height="15" /> width="17" height="15" />
</label> </label>
<input id="avatarInput" type="file" onChange={this.onAvatarSelected} /> <input id="avatarInput" type="file" onChange={this.onAvatarSelected} />
</AccessibleButton> </div>
</div> </div>
</div> </div>

1
src/components/views/elements/AppWarning.js
View File

@ -1,6 +1,5 @@
import React from 'react'; // eslint-disable-line no-unused-vars import React from 'react'; // eslint-disable-line no-unused-vars
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { _t } from '../../../languageHandler';
const AppWarning = (props) => { const AppWarning = (props) => {
return ( return (

2
src/components/views/globals/CookieBar.js
View File

@ -95,7 +95,7 @@ export default class CookieBar extends React.Component {
{ _t("Yes, I want to help!") } { _t("Yes, I want to help!") }
</AccessibleButton> </AccessibleButton>
<AccessibleButton className="mx_MatrixToolbar_close" onClick={this.onReject}> <AccessibleButton className="mx_MatrixToolbar_close" onClick={this.onReject}>
<img src="img/cancel.svg" width="18" height="18" alt={_t('Close')}/> <img src="img/cancel.svg" width="18" height="18" alt={_t('Close')} />
</AccessibleButton> </AccessibleButton>
</div> </div>
); );