You've already forked matrix-js-sdk
mirror of
https://github.com/matrix-org/matrix-js-sdk.git
synced 2025-11-25 05:23:13 +03:00
47a8d3e50a
The Google code style config for ESLint turns on `guard-for-in` to require for-in loops to check own properties. This makes it annoying to iterate objects, and we seem to disable the rule by line comments when it comes up anyway, so this just disables it globally.
87 lines
2.8 KiB
JavaScript
87 lines
2.8 KiB
JavaScript
module.exports = {
|
|
parser: "babel-eslint", // now needed for class properties
|
|
parserOptions: {
|
|
sourceType: "module",
|
|
ecmaFeatures: {
|
|
}
|
|
},
|
|
env: {
|
|
browser: true,
|
|
node: true,
|
|
|
|
// babel's transform-runtime converts references to ES6 globals such as
|
|
// Promise and Map to core-js polyfills, so we can use ES6 globals.
|
|
es6: true,
|
|
},
|
|
extends: ["eslint:recommended", "google"],
|
|
plugins: [
|
|
"babel",
|
|
],
|
|
rules: {
|
|
// rules we've always adhered to or now do
|
|
"max-len": ["error", {
|
|
code: 90,
|
|
ignoreComments: true,
|
|
}],
|
|
curly: ["error", "multi-line"],
|
|
"prefer-const": ["error"],
|
|
"comma-dangle": ["error", {
|
|
arrays: "always-multiline",
|
|
objects: "always-multiline",
|
|
imports: "always-multiline",
|
|
exports: "always-multiline",
|
|
functions: "always-multiline",
|
|
}],
|
|
|
|
// loosen jsdoc requirements a little
|
|
"require-jsdoc": ["error", {
|
|
require: {
|
|
FunctionDeclaration: false,
|
|
}
|
|
}],
|
|
"valid-jsdoc": ["error", {
|
|
requireParamDescription: false,
|
|
requireReturn: false,
|
|
requireReturnDescription: false,
|
|
}],
|
|
|
|
// rules we do not want from eslint-recommended
|
|
"no-console": ["off"],
|
|
"no-constant-condition": ["off"],
|
|
"no-empty": ["error", { "allowEmptyCatch": true }],
|
|
|
|
// rules we do not want from the google styleguide
|
|
"object-curly-spacing": ["off"],
|
|
"spaced-comment": ["off"],
|
|
"guard-for-in": ["off"],
|
|
|
|
// in principle we prefer single quotes, but life is too short
|
|
quotes: ["off"],
|
|
|
|
// rules we'd ideally like to adhere to, but the current
|
|
// code does not (in most cases because it's still ES5)
|
|
// we set these to warnings, and assert that the number
|
|
// of warnings doesn't exceed a given threshold
|
|
"no-var": ["warn"],
|
|
"brace-style": ["warn", "1tbs", {"allowSingleLine": true}],
|
|
"prefer-rest-params": ["warn"],
|
|
"prefer-spread": ["warn"],
|
|
"one-var": ["warn"],
|
|
"padded-blocks": ["warn"],
|
|
"no-extend-native": ["warn"],
|
|
"camelcase": ["warn"],
|
|
"no-multi-spaces": ["error", { "ignoreEOLComments": true }],
|
|
"space-before-function-paren": ["error", {
|
|
"anonymous": "never",
|
|
"named": "never",
|
|
"asyncArrow": "always",
|
|
}],
|
|
"arrow-parens": "off",
|
|
|
|
// eslint's built in no-invalid-this rule breaks with class properties
|
|
"no-invalid-this": "off",
|
|
// so we replace it with a version that is class property aware
|
|
"babel/no-invalid-this": "error",
|
|
}
|
|
}
|