1
0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-11-28 05:03:59 +03:00
Commit Graph

52 Commits

Author SHA1 Message Date
David Baker
9fb6eea8b7 Document what to use instead 2019-06-10 18:04:30 +01:00
David Baker
23c4f19cda lint 2019-06-10 16:29:55 +01:00
David Baker
3b34570749 doc background flag deprecation 2019-06-10 16:26:09 +01:00
David Baker
0412ca5810 make busyChanged optional 2019-06-10 16:24:20 +01:00
David Baker
c80518bf3e s/setBusy/busyChanged/ 2019-06-10 16:23:06 +01:00
David Baker
61ee6eb8af This should be null, not false
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
2019-06-10 16:19:45 +01:00
David Baker
654e8b41fa Don't overlap auth submissions with polls
Wait for polls to complete before submitting auth dicts, otherwise
we risk the requests overlapping and both returning a 200.

Also introduces a setBusy interface to interactive-auth to explicitly
set the busy status, since otherwise it doesn't get set until the
request actually starts.
2019-06-10 15:18:46 +01:00
David Baker
bac73150ca Don't send another token request while one's in flight
Otherwise we end up with more tokens than are strictly necessary
2019-06-06 19:03:29 +01:00
David Baker
ae9bcd6f6c Don't poll UI auth again until current poll finishes
On slow networks/servers we were ending up with lots of requests in
flight.
2019-06-06 18:31:54 +01:00
Janith Kasun
feed1da570 Merge branch 'develop' into loglevel-extend 2019-05-24 18:00:40 +05:30
David Baker
f83eae4a46 typing hard 2019-05-22 13:11:05 +01:00
David Baker
87c6d11fca PR feedback 2019-05-22 13:09:24 +01:00
David Baker
e87ac86e48 interactive-auth now handles requesting email tokens
interactive-auth now has a callback to request the email token which
it will call at the appropriate time (now at the start of the
auth process if the chosen flow contain an email auth stage).

This does make this a breaking change, although not sure this is
used outside of Riot. We could make it backwards compatible by
having an option for the new behaviour. It may not be worthwhile
though.

https://github.com/vector-im/riot-web/issues/9586
2019-05-22 11:51:05 +01:00
jkasun
a73dabcb67 Console logging to loglevel 2019-05-19 09:29:40 +05:30
Richard van der Hoff
eccea7411f Fix error handling in interactive-auth
Now that we are using bluebird, `defer.reject` is not implicitly bound, so we
need to call it properly rather than just passing it into the catch handler.

This fixes an error:

   promise.js:711 Uncaught TypeError: Cannot read property 'promise' of undefined
2017-08-21 16:31:42 +01:00
Richard van der Hoff
cfffbc4a09 replace q method calls with bluebird ones
```
find src spec -name '*.js' |
    xargs perl -i -pe 's/q\.(all|defer|reject|delay|try)\(/Promise.$1(/'
```
2017-07-12 23:33:55 +01:00
Richard van der Hoff
a5d3dd942e q(...) -> Promise.resolve
```
find src spec -name '*.js' |
    xargs perl -i -pe 's/\bq(\([^(]*\))/Promise.resolve$1/'
```
2017-07-12 23:32:28 +01:00
Richard van der Hoff
b96062b6de replace imports of q with bluebird
```
find src spec -name '*.js' |
   xargs perl -i -pe 'if (/require\(.q.\)/) { $_ = "import Promise from '\''bluebird'\'';\n"; }'

find src spec -name '*.js' |
   xargs perl -i -pe 'if (/import q/) { $_ = "import Promise from '\''bluebird'\'';\n"; }'
```
2017-07-12 23:32:28 +01:00
David Baker
68d9662fe5 Automatically complete dummy auth
Dummy auth flows, bu definition, do not require a response from
the user, and so should just be completed automatically by
interactive-auth.
2017-04-12 18:36:23 +01:00
David Baker
66ce31f6d6 Add docs. 2017-03-21 18:40:00 +00:00
David Baker
cf486aedbd Extend 'ignoreFailure' to be 'background'
This allows us to also use it to decide whether or not to show
the app as busy in the UI. We pass this flag up into the
makeRequest callback so it can use it as such.
2017-03-21 18:37:08 +00:00
David Baker
421a35c201 Stray brace 2017-03-16 12:33:24 +00:00
David Baker
fcfc7b6cec Better doc & throw consistently 2017-03-16 12:02:06 +00:00
David Baker
6c2e8eba1c Do no-auth-flow error handling more properly 2017-03-15 16:42:57 +00:00
David Baker
c9c3937f4b Move exception throw into _chooseFlow 2017-03-15 14:33:31 +00:00
David Baker
7777cbf6da Lint 2017-03-15 14:21:34 +00:00
David Baker
a8a7d327ff Give a better error message
if the HS doesn't support msisdn registeration
2017-03-15 14:14:04 +00:00
David Baker
8b4b0e0d39 Save the completed flows (#389)
Otherwise we get very confused and go back to the start when given
a response with no flows etc.

Only copy data if none of the 3 fields are defined, since that's
more the situation we actually want to handle.
2017-03-15 11:15:35 +00:00
David Baker
8f790d406f Fix lint (add jsdoc) 2017-03-06 09:27:29 +00:00
David Baker
7e2a256229 Add getEmailSid
Other places sometimes need to re-use the email sid to send proof
of ownership of a email address to somewhere else.
2017-03-03 17:40:26 +00:00
David Baker
1d591034ff Doc sid param 2017-03-03 10:15:09 +00:00
David Baker
3c246a97e8 More docs 2017-03-02 14:15:43 +00:00
David Baker
ca395541b6 Backwards compat 2017-03-02 14:09:08 +00:00
David Baker
30d9dec438 Doc error objects pass to stage update 2017-03-02 14:07:25 +00:00
David Baker
bdae9521cb Copy session ID too 2017-03-01 17:35:18 +00:00
David Baker
cb7fb6c7be Keep data from response in any case
Fix up flows if they're absent
2017-03-01 17:10:08 +00:00
David Baker
a33e4477af Comment the ignoring of failures 2017-03-01 16:35:37 +00:00
David Baker
d435192e22 Remove unnecesary check 2017-03-01 16:33:55 +00:00
David Baker
9480447637 Comment stageState 2017-03-01 16:09:43 +00:00
David Baker
7dbe852606 Comment why we choose flows 2017-03-01 16:07:31 +00:00
David Baker
d7216f44f5 PR feedback: Move requestEmailToken...
...to the UI component (in react-sdk)
2017-03-01 16:02:50 +00:00
David Baker
32360e7473 Lint 2017-02-28 14:13:50 +00:00
David Baker
90482377b7 Fix linting 2017-02-28 14:08:41 +00:00
David Baker
08a3aea1c7 Fix tests 2017-02-28 13:44:44 +00:00
David Baker
6eebd1e957 Ignore failures when polling for auth completion 2017-02-27 17:23:02 +00:00
David Baker
033bd9bbdc Support polling
for out-of-band auth completion
2017-02-24 17:22:57 +00:00
David Baker
af634d3a7d Add m.login.email.identity support to UI auth
Extends the interactive-auth to support m.login.email.identity
This also includes the ability to resume a UI auth session given
the approirpiate information (ie. to resume the auth flow having
click a link in a verification email).
2017-02-24 11:18:21 +00:00
David Baker
423175f539 eslint --fix for dangley commas on function calls 2017-01-20 16:12:02 +00:00
David Baker
7bca05af64 eslint ---fix for prefer-const 2017-01-19 17:42:10 +00:00
Kegan Dougal
7ed65407e6 Pass through eslint --fix 2017-01-13 10:49:32 +00:00