R Midhun Suresh
30aa66e680
Improve CONTRIBUTING.md
and add code_style.md
( #4708 )
...
* Fix typo in README
* Add proper contributing guide
This is based on the same in element-web repo but with the following
changes:
1. Uses sign-off instead of CLA
2. Removes react, app specific instructions eg: tests do not mention
playwright.
* Add code_style.md
Copied from element-web repo but react/css specific items have been
removed.
* Fix lint
2025-02-12 17:45:45 +00:00
Michael Weimann
349c2c2587
Apply prettier formatting
2022-12-09 09:38:20 +01:00
Michael Weimann
207171efd6
Link contributing to Element Web ( #2621 )
2022-09-01 13:49:47 +02:00
Eric Eastwood
96c35e2dd3
Add more detail on the context/rationale that should be included when contributing ( #2432 )
...
Follow-up to https://github.com/matrix-org/matrix-js-sdk/pull/1933
Spawning from various recent documents and comments:
- https://github.com/vector-im/element-meta/wiki/Review-process
- https://github.com/matrix-org/synapse/pull/12846#discussion_r887270734
- https://gitlab.matrix.org/new-vector/internal/-/wikis/Backend/Reviews
2022-06-07 08:52:08 -05:00
Michael Telatynski
d73126ecb2
Document how to inhibit code coverage requirement ( #2436 )
...
on specific sections
2022-06-06 13:13:16 +00:00
Michael Telatynski
c7f6777e48
Update CONTRIBUTING.md ( #2380 )
2022-05-17 18:18:19 +00:00
Michael Telatynski
aa283a3c9e
Update CONTRIBUTING.md ( #2329 )
2022-04-28 15:48:21 +01:00
James Salter
905a884f72
Formalise guidelines around writing tests ( #2179 )
2022-03-17 09:10:12 +00:00
David Baker
f6ce0c581e
Add tests requirements to CONTRIBUTING
...
Fixes https://github.com/vector-im/element-web/issues/19136
2021-09-23 14:09:01 +01:00
Eric Eastwood
3705426b6d
Make PR's easier to review
2021-09-16 16:05:49 -05:00
David Baker
45c153321c
Use X-Breaking-Change
...
Apparently we already have this label in react SDK (for some reason)
so let's use it. Plus, it's clearer that it's for changes rather than
issues that cause things to break.
2021-07-14 22:46:22 +01:00
David Baker
19aedebff1
Update other label mentions
2021-07-14 22:16:00 +01:00
David Baker
5392f616b4
Use existing issues labels / scheme
...
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com >
2021-07-14 22:15:18 +01:00
David Baker
c4ccb9d493
Use a real-life example which should hopefully be clearer
2021-07-14 22:00:42 +01:00
David Baker
b0726b5008
On brand ourself
...
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com >
2021-07-14 21:57:48 +01:00
David Baker
9c221419ef
On-brand
...
Co-authored-by: J. Ryan Stinnett <jryans@gmail.com >
2021-07-14 21:57:29 +01:00
David Baker
fddf0c47fb
Fix formatting
...
Co-authored-by: Šimon Brandner <simon.bra.ag@gmail.com >
2021-07-14 21:57:04 +01:00
David Baker
b17862e212
s/tag/label/
...
Also make breaking change notation clearer.
2021-07-14 19:55:58 +01:00
David Baker
ee5a0e7edf
Internal PRs shouldn't have changelog entries by default
2021-07-14 19:47:46 +01:00
David Baker
b538c06fcb
Update contributing guidelines to for new changelog stuff
2021-07-14 19:45:42 +01:00
David Baker
20bd9b525b
Convert CONTRIBUTING to markdown
...
Because everything else is
2021-07-14 19:02:03 +01:00