matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-11-26 17:03:12 +03:00
Code Activity

Improve thread deduplication thread process

Browse Source 
Some threads were still holding a reference to the original thread models they were assigned to, leading to some unexpected timeline rendering
This commit is contained in:
Germain Souquet
2021-09-07 15:05:45 +01:00
parent 324f9e58ea
commit e97d18a03b
4 changed files with 51 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/models/thread.ts
View File

@@ -31,7 +31,7 @@ export class Thread extends EventEmitter {
/**
* A reference to all the events ID at the bottom of the threads
*/
public tail = new Set<string>();
public readonly tail = new Set<string>();
private _timelineSet: EventTimelineSet;
constructor(
@@ -155,7 +155,7 @@ export class Thread extends EventEmitter {
* The number of messages in the thread
*/
public get length(): number {
return this._timelineSet.getLiveTimeline().getEvents().length;
return this.events.length;
}
/**
@@ -163,7 +163,7 @@ export class Thread extends EventEmitter {
*/
public get participants(): Set<string> {
const participants = new Set<string>();
this._timelineSet.getLiveTimeline().getEvents().forEach(event => {
this.events.forEach(event => {
participants.add(event.getSender());
});
return participants;
@@ -180,7 +180,18 @@ export class Thread extends EventEmitter {
* A getter for the last event added to the thread
*/
public get replyToEvent(): MatrixEvent {
const events = this._timelineSet.getLiveTimeline().getEvents();
const events = this.events;
return events[events.length -1];
}
public get events(): MatrixEvent[] {
return this._timelineSet.getLiveTimeline().getEvents();
}
public merge(thread: Thread): void {
thread.events.forEach(event => {
this.addEvent(event);
});
this.events.forEach(event => event.setThread(this));
}
}