matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-07-31 15:24:23 +03:00
Code Activity

Total summary count (#3351)

Browse Source 
* add audio concealment to stats report

* audio concealment to summary

* make ts linter happy

* format and rename

* fix and add tests

* make it prettier!

* we can make it even prettier ?!

* review

* fix tests

* pretty

* one empty line to ...

* remove ratio in audio concealment (ratio is now done in the summary)

* remove comment

* fix test

* add peer connections to summary report

* tests
This commit is contained in:
Timo
2023-05-14 18:58:38 +02:00
committed by GitHub
parent aaae55736f
commit e6a3b0ebc0
3 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/unit/webrtc/stats/summaryStatsReporter.spec.ts
View File

@ -125,6 +125,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 0.75, percentageReceivedVideoMedia: 0.75,
maxJitter: 0, maxJitter: 0,
maxPacketLoss: 0, maxPacketLoss: 0,
peerConnections: 4,
percentageConcealedAudio: 0.0375, percentageConcealedAudio: 0.0375,
}); });
}); });
@ -160,6 +161,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1, percentageReceivedVideoMedia: 1,
maxJitter: 0, maxJitter: 0,
maxPacketLoss: 0, maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0, percentageConcealedAudio: 0,
}); });
}); });
@ -195,6 +197,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 0, percentageReceivedVideoMedia: 0,
maxJitter: 0, maxJitter: 0,
maxPacketLoss: 0, maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0, percentageConcealedAudio: 0,
}); });
}); });
@ -230,6 +233,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1, percentageReceivedVideoMedia: 1,
maxJitter: 0, maxJitter: 0,
maxPacketLoss: 0, maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0, percentageConcealedAudio: 0,
}); });
}); });
@ -328,6 +332,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1, percentageReceivedVideoMedia: 1,
maxJitter: 20, maxJitter: 20,
maxPacketLoss: 40, maxPacketLoss: 40,
peerConnections: 4,
percentageConcealedAudio: 0, percentageConcealedAudio: 0,
}); });
}); });
@ -363,6 +368,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1, percentageReceivedVideoMedia: 1,
maxJitter: 0, maxJitter: 0,
maxPacketLoss: 0, maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0, percentageConcealedAudio: 0,
}); });
}); });
@ -398,6 +404,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1, percentageReceivedVideoMedia: 1,
maxJitter: 0, maxJitter: 0,
maxPacketLoss: 0, maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0, percentageConcealedAudio: 0,
}); });
}); });
@ -433,6 +440,7 @@ describe("SummaryStatsReporter", () => {
percentageReceivedVideoMedia: 1, percentageReceivedVideoMedia: 1,
maxJitter: 0, maxJitter: 0,
maxPacketLoss: 0, maxPacketLoss: 0,
peerConnections: 1,
percentageConcealedAudio: 0, percentageConcealedAudio: 0,
}); });
}); });

1
src/webrtc/stats/statsReport.ts
View File

@ -78,4 +78,5 @@ export interface SummaryStatsReport {
maxJitter: number; maxJitter: number;
maxPacketLoss: number; maxPacketLoss: number;
percentageConcealedAudio: number; percentageConcealedAudio: number;
peerConnections: number;
} }

1
src/webrtc/stats/summaryStatsReporter.ts
View File

@ -61,6 +61,7 @@ export class SummaryStatsReporter {
? (summaryCounter.concealedAudio / summaryCounter.totalAudio).toFixed(decimalPlaces) ? (summaryCounter.concealedAudio / summaryCounter.totalAudio).toFixed(decimalPlaces)
: 0, : 0,
), ),
peerConnections: summaryTotalCount,
} as SummaryStatsReport; } as SummaryStatsReport;
this.emitter.emitSummaryStatsReport(report); this.emitter.emitSummaryStatsReport(report);
} }