matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-11-28 05:03:59 +03:00
Code Activity

Make unknown pushrule conditions not match

Browse Source 
Unknown conditions previously were assumed to match, but given rules
can be added on the server as base rules, it's probably better to not
match unknown conditions.
This commit is contained in:
David Baker
2017-10-16 13:55:07 +01:00
parent 24ef004adc
commit d9addf84ef
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/pushprocessor.js
View File

@@ -1,5 +1,6 @@
/* /*
Copyright 2015, 2016 OpenMarket Ltd Copyright 2015, 2016 OpenMarket Ltd
Copyright 2017 New Vector Ltd
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.
@@ -126,7 +127,10 @@ function PushProcessor(client) {
if (condition_functions[cond.kind]) { if (condition_functions[cond.kind]) {
return condition_functions[cond.kind](cond, ev); return condition_functions[cond.kind](cond, ev);
} }
return true; // unknown conditions: we previously matched all unknown conditions,
// but given that rules can be added to the base rules on a server,
// it's probably better to not match unknown conditions.
return false;
}; };
const eventFulfillsRoomMemberCountCondition = function(cond, ev) { const eventFulfillsRoomMemberCountCondition = function(cond, ev) {