1
0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-07-30 04:23:07 +03:00

Don't use event.sender in CallMembership (#3793)

* Don't use event.sender in CallMembership

I fell into another js-sdk trap: this is "only guaranteed to be set
for events that appear in a timeline" and not state events. It does
not say why. We only ever used it to get the sender user ID anyway,
so just use getSender().

* Fix test
This commit is contained in:
David Baker
2023-10-10 16:19:52 +01:00
committed by GitHub
parent 2f79e6c056
commit c8f8fb587d
3 changed files with 6 additions and 8 deletions

View File

@ -29,9 +29,7 @@ const membershipTemplate: CallMembershipData = {
function makeMockEvent(originTs = 0): MatrixEvent {
return {
getTs: jest.fn().mockReturnValue(originTs),
sender: {
userId: "@alice:example.org",
},
getSender: jest.fn().mockReturnValue("@alice:example.org"),
} as unknown as MatrixEvent;
}