Fix logging of DecryptionErrors to be more useful

We were relying on being able to override toString in DecryptionError, which
(a) doesn't work thanks to https://github.com/babel/babel/issues/3083, and (b)
was a bit naughty anyway. Instead, just add a detailedString property and use
that.

src/crypto/algorithms/base.js

@@ -179,21 +179,18 @@ class DecryptionError extends Error {
     constructor(msg, details) {
         super(msg);
         this.name = 'DecryptionError';
-        this.details = details;
+        this.detailedString = _detailedStringForDecryptionError(this, details);
     }
+}
+export {DecryptionError}; // https://github.com/jsdoc3/jsdoc/issues/1272
 
-    /**
-     * override the string used when logging
-     *
-     * @returns {String}
-     */
-    toString() {
-        let result = this.name + '[msg: ' + this.message;
+function _detailedStringForDecryptionError(err, details) {
+    let result = err.name + '[msg: ' + err.message;
 
-        if (this.details) {
+    if (details) {
         result += ', ' +
-                Object.keys(this.details).map(
-                    (k) => k + ': ' + this.details[k],
+            Object.keys(details).map(
+                (k) => k + ': ' + details[k],
             ).join(', ');
     }
 
@@ -201,8 +198,6 @@ class DecryptionError extends Error {
 
     return result;
 }
-}
-export {DecryptionError}; // https://github.com/jsdoc3/jsdoc/issues/1272
 
 /**
  * Exception thrown specifically when we want to warn the user to consider

src/models/event.js

@@ -424,7 +424,7 @@ utils.extend(module.exports.MatrixEvent.prototype, {
                     // decryption error, but we have a retry queued.
                     console.log(
                         `Got error decrypting event (id=${this.getId()}: ` +
-                        `${e.message}), but retrying`,
+                        `${e}), but retrying`,
                     );
                     continue;
                 }
@@ -432,7 +432,7 @@ utils.extend(module.exports.MatrixEvent.prototype, {
                 // decryption error, no retries queued. Warn about the error and
                 // set it to m.bad.encrypted.
                 console.warn(
-                    `Error decrypting event (id=${this.getId()}): ${e}`,
+                    `Error decrypting event (id=${this.getId()}): ${e.detailedString}`,
                 );
 
                 res = this._badEncryptedMessage(e.message);