matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-12-01 04:43:29 +03:00
Code Activity

Remove RTX codec hack as the issue is no longer present on Chromium 90

Browse Source 
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
This commit is contained in:
Šimon Brandner
2021-09-15 16:38:59 +02:00
parent 8544aca362
commit be942fd66a
1 changed files with 0 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/webrtc/call.ts
View File

@@ -1068,7 +1068,6 @@ export class MatrixCall extends EventEmitter {
let myAnswer; let myAnswer;
try { try {
this.getRidOfRTXCodecs();
myAnswer = await this.peerConn.createAnswer(); myAnswer = await this.peerConn.createAnswer();
} catch (err) { } catch (err) {
logger.debug("Failed to create answer: ", err); logger.debug("Failed to create answer: ", err);
@@ -1285,7 +1284,6 @@ export class MatrixCall extends EventEmitter {
await this.peerConn.setRemoteDescription(description); await this.peerConn.setRemoteDescription(description);
if (description.type === 'offer') { if (description.type === 'offer') {
this.getRidOfRTXCodecs();
const localDescription = await this.peerConn.createAnswer(); const localDescription = await this.peerConn.createAnswer();
await this.peerConn.setLocalDescription(localDescription); await this.peerConn.setLocalDescription(localDescription);
@@ -1499,47 +1497,6 @@ export class MatrixCall extends EventEmitter {
stream.addEventListener("removetrack", () => this.deleteFeedByStream(stream)); stream.addEventListener("removetrack", () => this.deleteFeedByStream(stream));
}; };
/**
* This method removes all video/rtx codecs from screensharing video
* transceivers. This is necessary since they can cause problems. Without
* this the following steps should produce an error:
* Chromium calls Firefox
* Firefox answers
* Firefox starts screen-sharing
* Chromium starts screen-sharing
* Call crashes for Chromium with:
* [96685:23:0518/162603.933321:ERROR:webrtc_video_engine.cc(3296)] RTX codec (PT=97) mapped to PT=96 which is not in the codec list.
* [96685:23:0518/162603.933377:ERROR:webrtc_video_engine.cc(1171)] GetChangedRecvParameters called without any video codecs.
* [96685:23:0518/162603.933430:ERROR:sdp_offer_answer.cc(4302)] Failed to set local video description recv parameters for m-section with mid='2'. (INVALID_PARAMETER)
*/
private getRidOfRTXCodecs(): void {
// RTCRtpReceiver.getCapabilities and RTCRtpSender.getCapabilities don't seem to be supported on FF
if (!RTCRtpReceiver.getCapabilities || !RTCRtpSender.getCapabilities) return;
const recvCodecs = RTCRtpReceiver.getCapabilities("video").codecs;
const sendCodecs = RTCRtpSender.getCapabilities("video").codecs;
const codecs = [...sendCodecs, ...recvCodecs];
for (const codec of codecs) {
if (codec.mimeType === "video/rtx") {
const rtxCodecIndex = codecs.indexOf(codec);
codecs.splice(rtxCodecIndex, 1);
}
}
for (const trans of this.peerConn.getTransceivers()) {
if (
this.screensharingSenders.includes(trans.sender) &&
(
trans.sender.track?.kind === "video" ||
trans.receiver.track?.kind === "video"
)
) {
trans.setCodecPreferences(codecs);
}
}
}
private onNegotiationNeeded = async (): Promise<void> => { private onNegotiationNeeded = async (): Promise<void> => {
logger.info("Negotiation is needed!"); logger.info("Negotiation is needed!");
@@ -1550,7 +1507,6 @@ export class MatrixCall extends EventEmitter {
this.makingOffer = true; this.makingOffer = true;
try { try {
this.getRidOfRTXCodecs();
const myOffer = await this.peerConn.createOffer(); const myOffer = await this.peerConn.createOffer();
await this.gotLocalOffer(myOffer); await this.gotLocalOffer(myOffer);
} catch (e) { } catch (e) {