matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-11-25 05:23:13 +03:00
Code Activity

Replace instanceof Array with Array.isArray (#2812)

Browse Source
This commit is contained in:
Michael Telatynski
2022-10-26 17:59:16 +01:00
committed by GitHub
parent 6f2390a765
commit b44787192d
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/crypto/verification/SAS.ts
View File

@@ -217,7 +217,7 @@ const MAC_SET = new Set(MAC_LIST);
const SAS_SET = new Set(SAS_LIST);
function intersection<T>(anArray: T[], aSet: Set<T>): T[] {
return anArray instanceof Array ? anArray.filter(x => aSet.has(x)) : [];
return Array.isArray(anArray) ? anArray.filter(x => aSet.has(x)) : [];
}
export enum SasEvent {

2
src/sliding-sync-sdk.ts
View File

@@ -82,7 +82,7 @@ class ExtensionE2EE implements Extension {
const unusedFallbackKeys = data["device_unused_fallback_key_types"] ||
data["org.matrix.msc2732.device_unused_fallback_key_types"];
this.crypto.setNeedsNewFallback(
unusedFallbackKeys instanceof Array &&
Array.isArray(unusedFallbackKeys) &&
!unusedFallbackKeys.includes("signed_curve25519"),
);
}

2
src/sync.ts
View File

@@ -1482,7 +1482,7 @@ export class SyncApi {
const unusedFallbackKeys = data["device_unused_fallback_key_types"] ||
data["org.matrix.msc2732.device_unused_fallback_key_types"];
this.opts.crypto.setNeedsNewFallback(
unusedFallbackKeys instanceof Array &&
Array.isArray(unusedFallbackKeys) &&
!unusedFallbackKeys.includes("signed_curve25519"),
);
}

2
src/utils.ts
View File

@@ -232,7 +232,7 @@ export function deepCompare(x: any, y: any): boolean {
}
// the object algorithm works for Array, but it's sub-optimal.
if (x instanceof Array) {
if (Array.isArray(x)) {
if (x.length !== y.length) {
return false;
}