matrix/matrix-js-sdk
1
0
Fork 0
mirror of https://github.com/matrix-org/matrix-js-sdk.git synced 2025-11-25 05:23:13 +03:00
Code Activity

Log real errors and not just their messages, traces are useful (#2464)

Browse Source
This commit is contained in:
Michael Telatynski
2022-06-15 13:44:42 +01:00
committed by GitHub
parent d3ff7655f7
commit b43b4aa9f9
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/crypto/index.ts
View File

@@ -3284,7 +3284,7 @@ export class Crypto extends TypedEventEmitter<CryptoEvent, CryptoEventHandlerMap
event.on(MatrixEventEvent.Status, statusListener); event.on(MatrixEventEvent.Status, statusListener);
}); });
} catch (err) { } catch (err) {
logger.error("error while waiting for the verification event to be sent: " + err.message); logger.error("error while waiting for the verification event to be sent: ", err);
return; return;
} finally { } finally {
event.removeListener(MatrixEventEvent.LocalEventIdReplaced, eventIdListener); event.removeListener(MatrixEventEvent.LocalEventIdReplaced, eventIdListener);
@@ -3308,7 +3308,7 @@ export class Crypto extends TypedEventEmitter<CryptoEvent, CryptoEventHandlerMap
try { try {
await request.channel.handleEvent(event, request, isLiveEvent); await request.channel.handleEvent(event, request, isLiveEvent);
} catch (err) { } catch (err) {
logger.error("error while handling verification event: " + err.message); logger.error("error while handling verification event", err);
} }
const shouldEmit = isNewRequest && const shouldEmit = isNewRequest &&
!request.initiatedByMe && !request.initiatedByMe &&

3
src/store/indexeddb-store-worker.ts
View File

@@ -122,8 +122,7 @@ export class IndexedDBStoreWorker {
result: ret, result: ret,
}); });
}, (err) => { }, (err) => {
logger.error("Error running command: " + msg.command); logger.error("Error running command: " + msg.command, err);
logger.error(err);
this.postMessage.call(null, { this.postMessage.call(null, {
command: 'cmd_fail', command: 'cmd_fail',
seq: msg.seq, seq: msg.seq,